Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2.17 documentation #1893

Merged
merged 3 commits into from
Dec 5, 2024
Merged

2.17 documentation #1893

merged 3 commits into from
Dec 5, 2024

Conversation

kflynn
Copy link
Member

@kflynn kflynn commented Dec 4, 2024

Signed-off-by: Flynn [email protected]

Signed-off-by: Flynn <[email protected]>
@kflynn kflynn requested a review from travisbeckham December 4, 2024 18:36
Copy link
Collaborator

@travisbeckham travisbeckham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!
I added a couple comments on the new feature docs, then I think it's ready to go.

linkerd.io/content/2.17/features/egress.md Outdated Show resolved Hide resolved
linkerd.io/content/2.17/features/egress.md Show resolved Hide resolved
@travisbeckham travisbeckham merged commit 99670ac into main Dec 5, 2024
7 checks passed
@travisbeckham travisbeckham deleted the flynn/2.17 branch December 5, 2024 13:58
name: httpbin-get
namespace: egress-test
spec:
parentRefs:

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

aren't you forgetting hostnames here? (similarly for the httproute near the bottom of this page)

  hostnames:
    - httpbin.org

GTRekter pushed a commit to GTRekter/website that referenced this pull request Dec 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants