Enforce review policy #9120 #102
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mhitza
commented
Nov 20, 2024
mhitza
commented
Nov 20, 2024
mhitza
commented
Nov 20, 2024
mhitza
force-pushed
the
review-policy-template-9120
branch
from
41384c3 to
ad7923b
Compare
Having this flag as an opt-in prevents situations where a developer working individually on a repository locks himself out from merging PRs and pushing to the master branch without going through additional hoops.
One controls the pull request review policy, and the second one prevents collaborators from pushing directly to the default branch (prevents commit merging as well, only doable by admins)
mhitza
force-pushed
the
review-policy-template-9120
branch
from
ad7923b to
9758bc1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Types of changes
Checklist