Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generated workflows and devcontainer cleanup #9358 #119

Merged
merged 9 commits into from
Jan 21, 2025

Conversation

mhitza
Copy link
Collaborator

@mhitza mhitza commented Jan 21, 2025

Types of changes

  • feat: non-breaking change which adds new functionality
  • fix: non-breaking change which fixes a bug or an issue
  • chore(deps): changes to dependencies
  • test: adds or modifies a test
  • docs: creates or updates documentation
  • style: changes that do not affect the meaning or function of code (e.g. formatting, whitespace, missing semi-colons etc.)
  • perf: code change that improves performance
  • revert: reverts a commit
  • refactor: code change that neither fix a bug nor add a new feature
  • ci: changes to continuous integration or continuous delivery scripts or configuration files
  • chore: general tasks or anything that doesn't fit the other commit types
  • Breaking change: fix or feature that would cause existing functionality to not work as expected

Checklist

The new format is a JavaScript module, which gives the option to attach
inline comments to the configuration file. It also makes it easier to
emphasis that the file is repo-ansible managed.
For many action steps the step name matched the action name. Simplify
the workflow by removing these redundant descriptions, and make
descriptions match the behaviour better where this wasn't the case.
While the workflow name will match the behavior now, it will also make
the workflow less proeminent on the repository actions tab, and placed
lower in the visual hierarchy.
Update workflow to pick up on the docs/partial changes (part of the
README.md file generation). Tweak comment posted on a PR.
@mhitza mhitza merged commit 9528db5 into main Jan 21, 2025
3 checks passed
@mhitza mhitza deleted the generated-workflows-cleanup-9358 branch January 21, 2025 02:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant