Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: version errors for new configurations #0000 #122

Merged
merged 1 commit into from
Jan 25, 2025
Merged

fix: version errors for new configurations #0000 #122

merged 1 commit into from
Jan 25, 2025

Conversation

mhitza
Copy link
Collaborator

@mhitza mhitza commented Jan 25, 2025

When repo-ansible was applied to newly setup repositories, it would fail to run because these new repositories didn't include a version field. Which was a recent addition in order to enable some form of migration across repo-ansible changes.

With this change, move the migration process before all the other tasks, and remove line that referenced the repo object during the migrations instead of the repo_yaml object

Types of changes

  • feat: non-breaking change which adds new functionality
  • fix: non-breaking change which fixes a bug or an issue
  • chore(deps): changes to dependencies
  • test: adds or modifies a test
  • docs: creates or updates documentation
  • style: changes that do not affect the meaning or function of code (e.g. formatting, whitespace, missing semi-colons etc.)
  • perf: code change that improves performance
  • revert: reverts a commit
  • refactor: code change that neither fix a bug nor add a new feature
  • ci: changes to continuous integration or continuous delivery scripts or configuration files
  • chore: general tasks or anything that doesn't fit the other commit types
  • Breaking change: fix or feature that would cause existing functionality to not work as expected

Checklist

@mhitza
fix: version errors for new configurations #0000
5ea2086 
When repo-ansible was applied to newly setup repositories, it would fail
to run because these new repositories didn't include a version field.
Which was a recent addition in order to enable some form of migration
across repo-ansible changes.

With this change, move the migration process before all the other tasks,
and remove line that referenced the `repo` object during the migrations
instead of the `repo_yaml` object
@mhitza mhitza merged commit bacbb42 into main Jan 25, 2025
3 checks passed
@mhitza mhitza deleted the fix-repo-ansible-on-new-projects-0000 branch January 25, 2025 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@mhitza