Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reviewdog container image #9082 #99

Merged
merged 1 commit into from
Dec 11, 2024
Merged

Conversation

mhitza
Copy link
Collaborator

@mhitza mhitza commented Nov 12, 2024

Creates a new workflow step (and container) in order to be able to use reviewdog to check code quality of php/twig/symfony based projects.

This has an opt-in mechanism, via a new reviewdog top-level property in the schema.

Removes configuration parts, such as yamllint due to large amounts of false positives, as well as switching to newer/alternative tools where the old ones are deprecated (eg twigcs-fixer -> twig-cs-fixer)

Types of changes

  • feat: non-breaking change which adds new functionality
  • fix: non-breaking change which fixes a bug or an issue
  • chore(deps): changes to dependencies
  • test: adds or modifies a test
  • docs: creates or updates documentation
  • style: changes that do not affect the meaning or function of code (e.g. formatting, whitespace, missing semi-colons etc.)
  • perf: code change that improves performance
  • revert: reverts a commit
  • refactor: code change that neither fix a bug nor add a new feature
  • ci: changes to continuous integration or continuous delivery scripts or configuration files
  • chore: general tasks or anything that doesn't fit the other commit types
  • Breaking change: fix or feature that would cause existing functionality to not work as expected

Checklist

@mhitza mhitza force-pushed the review-container-image-9082 branch from b27f626 to 15a3c63 Compare December 9, 2024 18:00
Creates a new workflow step (and container) in order to be able to use
reviewdog to check code quality of php/twig/symfony based projects.

This has an opt-in mechanism, via a new reviewdog top-level property in
the schema.

Removes configuration parts, such as yamllint due to large amounts of
false positives, as well as switching to newer/alternative tools where
the old ones are deprecated (eg twigcs-fixer -> twig-cs-fixer)
@mhitza mhitza force-pushed the review-container-image-9082 branch from b2d83c8 to 7575bbe Compare December 11, 2024 17:17
@mhitza mhitza changed the title Reviewdog container image 9082 Reviewdog container image #9082 Dec 11, 2024
@mhitza mhitza marked this pull request as ready for review December 11, 2024 17:18
@mhitza mhitza merged commit ada194a into main Dec 11, 2024
5 checks passed
@mhitza mhitza deleted the review-container-image-9082 branch December 11, 2024 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant