Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[test] Allow to use different linode uri #372

Merged
merged 5 commits into from
Feb 13, 2025
Merged

[test] Allow to use different linode uri #372

merged 5 commits into from
Feb 13, 2025

Conversation

Michkov
Copy link
Contributor

@Michkov Michkov commented Feb 10, 2025

  • Get linode token and url from linode secret under kube-system
  • Count number of nodes using chainsaw function
  • Allow to define KUBECONFIG file in Makefile

General:

  • Have you removed all sensitive information, including but not limited to access keys and passwords?
  • Have you checked to ensure there aren't other open or closed Pull Requests for the same bug/feature/question?

Pull Request Guidelines:

  1. Does your submission pass tests?
  2. Have you added tests?
  3. Are you addressing a single feature in this PR?
  4. Are your commits atomic, addressing one change per commit?
  5. Are you following the conventions of the language?
  6. Have you saved your large formatting changes for a different PR, so we can focus on your work?
  7. Have you explained your rationale for why this feature is needed?
  8. Have you linked your PR to an open issue

- Get linode token and url from linode secret under kube-system
- Count number of nodes using chainsaw function
- Allow to define KUBECONFIG file in Makefile
@Michkov Michkov requested review from a team as code owners February 10, 2025 15:35
Makefile Show resolved Hide resolved
tests/csi-sanity/mkdir_in_pod.sh Outdated Show resolved Hide resolved
Copy link

codecov bot commented Feb 11, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.11%. Comparing base (d1ddbed) to head (3d6d1c9).
Report is 6 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #372   +/-   ##
=======================================
  Coverage   73.11%   73.11%           
=======================================
  Files          23       23           
  Lines        2648     2648           
=======================================
  Hits         1936     1936           
  Misses        585      585           
  Partials      127      127           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

komer3
komer3 previously approved these changes Feb 11, 2025
@komer3 komer3 dismissed their stale review February 11, 2025 16:05

Need to merge bugfix for e2e test from main branch

Check control-plane from role label not from nodename - removing
dependency on kind cluster.
@Michkov Michkov merged commit 8c92e50 into main Feb 13, 2025
8 checks passed
@Michkov Michkov deleted the test-outside branch February 13, 2025 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants