Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Cillium LoadBalancer regionIDMap #244

Merged
merged 2 commits into from
Nov 15, 2024

Conversation

mjurosz
Copy link
Contributor

@mjurosz mjurosz commented Nov 15, 2024

Update Cillium LoadBalancer regionIDMap to be up-to-date with available docs [1].

[1] https://techdocs.akamai.com/cloud-computing/docs/configure-failover-on-a-compute-instance#ip-sharing-availability

General:

  • Have you removed all sensitive information, including but not limited to access keys and passwords?
  • Have you checked to ensure there aren't other open or closed Pull Requests for the same bug/feature/question?

Pull Request Guidelines:

  1. Does your submission pass tests?
  2. Have you added tests?
  3. Are you addressing a single feature in this PR?
  4. Are your commits atomic, addressing one change per commit?
  5. Are you following the conventions of the language?
  6. Have you saved your large formatting changes for a different PR, so we can focus on your work?
  7. Have you explained your rationale for why this feature is needed?
  8. Have you linked your PR to an open issue

Copy link

codecov bot commented Nov 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.06%. Comparing base (e3c2045) to head (be99548).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #244   +/-   ##
=======================================
  Coverage   56.06%   56.06%           
=======================================
  Files          12       12           
  Lines        2349     2349           
=======================================
  Hits         1317     1317           
  Misses        881      881           
  Partials      151      151           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mjurosz mjurosz marked this pull request as ready for review November 15, 2024 11:01
@mjurosz
Copy link
Contributor Author

mjurosz commented Nov 15, 2024

Diff of docs page and code:
image

@mabojars mabojars self-requested a review November 15, 2024 11:23
Copy link

@mabojars mabojars left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Verified ID to slug mapping against DB.

@mjurosz mjurosz merged commit f67f48b into linode:main Nov 15, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants