Merge branch 'develop' into M3-8945-update-yup-to-v1

packages/api-v4/.changeset/pr-11337-added-1732714186488.md

@@ -0,0 +1,5 @@
+---
+"@linode/api-v4": Added
+---
+
+Linter rules for naming convention ([#11337](https://github.com/linode/manager/pull/11337))

packages/api-v4/.eslintrc.json

@@ -13,6 +13,42 @@
     "plugin:prettier/recommended"
   ],
   "rules": {
+    "@typescript-eslint/naming-convention": [
+      "warn",
+      {
+        "format": ["camelCase", "UPPER_CASE", "PascalCase"],
+        "leadingUnderscore": "allow",
+        "selector": "variable",
+        "trailingUnderscore": "allow"
+      },
+      {
+        "format": null,
+        "modifiers": ["destructured"],
+        "selector": "variable"
+      },
+      {
+        "format": ["camelCase", "PascalCase"],
+        "selector": "function"
+      },
+      {
+        "format": ["camelCase"],
+        "leadingUnderscore": "allow",
+        "selector": "parameter"
+      },
+      {
+        "format": ["PascalCase"],
+        "selector": "typeLike"
+      }
+    ],
+    "@typescript-eslint/no-unused-vars": "off",
+    "@typescript-eslint/no-inferrable-types": "off",
+    "@typescript-eslint/no-namespace": "warn",
+    "@typescript-eslint/explicit-function-return-type": "off",
+    "@typescript-eslint/no-empty-interface": "warn",
+    "@typescript-eslint/no-non-null-assertion": "off",
+    "@typescript-eslint/no-explicit-any": "warn",
+    "@typescript-eslint/no-use-before-define": "off",
+    "@typescript-eslint/interface-name-prefix": "off",
     "no-unused-vars": [
       "warn",
       {
@@ -33,15 +69,6 @@
     "no-console": "error",
     "no-undef-init": "off",
     "radix": "error",
-    "@typescript-eslint/no-unused-vars": "off",
-    "@typescript-eslint/no-inferrable-types": "off",
-    "@typescript-eslint/no-namespace": "warn",
-    "@typescript-eslint/explicit-function-return-type": "off",
-    "@typescript-eslint/no-empty-interface": "warn",
-    "@typescript-eslint/no-non-null-assertion": "off",
-    "@typescript-eslint/no-explicit-any": "warn",
-    "@typescript-eslint/no-use-before-define": "off",
-    "@typescript-eslint/interface-name-prefix": "off",
     "sonarjs/cognitive-complexity": "warn",
     "sonarjs/no-duplicate-string": "warn",
     "sonarjs/prefer-immediate-return": "warn",

packages/manager/.changeset/pr-11336-added-1732711112187.md

@@ -0,0 +1,5 @@
+---
+"@linode/manager": Added
+---
+
+unit test cases for `DocsLink` component ([#11336](https://github.com/linode/manager/pull/11336))

packages/manager/.changeset/pr-11337-added-1732714227095.md

@@ -0,0 +1,5 @@
+---
+"@linode/manager": Added
+---
+
+Linter rules for naming convention ([#11337](https://github.com/linode/manager/pull/11337))

packages/manager/.eslintrc.cjs

@@ -164,6 +164,33 @@ module.exports = {
     '@typescript-eslint/explicit-function-return-type': 'off',
     '@typescript-eslint/explicit-module-boundary-types': 'off',
     '@typescript-eslint/interface-name-prefix': 'off',
+    '@typescript-eslint/naming-convention': [
+      'warn',
+      {
+        format: ['camelCase', 'UPPER_CASE', 'PascalCase'],
+        leadingUnderscore: 'allow',
+        selector: 'variable',
+        trailingUnderscore: 'allow',
+      },
+      {
+        format: null,
+        modifiers: ['destructured'],
+        selector: 'variable',
+      },
+      {
+        format: ['camelCase', 'PascalCase'],
+        selector: 'function',
+      },
+      {
+        format: ['camelCase'],
+        leadingUnderscore: 'allow',
+        selector: 'parameter',
+      },
+      {
+        format: ['PascalCase'],
+        selector: 'typeLike',
+      },
+    ],
     '@typescript-eslint/no-empty-interface': 'warn',
     '@typescript-eslint/no-explicit-any': 'warn',
     '@typescript-eslint/no-inferrable-types': 'off',

packages/manager/src/components/DocsLink/DocsLink.test.tsx

@@ -0,0 +1,45 @@
+import userEvent from '@testing-library/user-event';
+import React from 'react';
+
+import { sendHelpButtonClickEvent } from 'src/utilities/analytics/customEventAnalytics';
+import { renderWithTheme } from 'src/utilities/testHelpers';
+
+import { DocsLink } from './DocsLink';
+
+import type { DocsLinkProps } from './DocsLink';
+
+vi.mock('src/utilities/analytics/customEventAnalytics', () => ({
+  sendHelpButtonClickEvent: vi.fn(),
+}));
+
+const mockLabel = 'Custom Doc Link Label';
+const mockHref =
+  'https://techdocs.akamai.com/cloud-computing/docs/faqs-for-compute-instances';
+const mockAnalyticsLabel = 'Label';
+
+const defaultProps: DocsLinkProps = {
+  analyticsLabel: mockAnalyticsLabel,
+  href: mockHref,
+  label: mockLabel,
+};
+
+describe('DocsLink', () => {
+  it('should render the label', () => {
+    const { getByText } = renderWithTheme(<DocsLink {...defaultProps} />);
+    expect(getByText(mockLabel)).toBeVisible();
+  });
+
+  it('should allow user to click the label and redirect to the url', async () => {
+    const { getByRole } = renderWithTheme(<DocsLink {...defaultProps} />);
+    const link = getByRole('link', {
+      name: 'Custom Doc Link Label - link opens in a new tab',
+    });
+    expect(link).toBeInTheDocument();
+    await userEvent.click(link);
+    expect(sendHelpButtonClickEvent).toHaveBeenCalledTimes(1);
+    expect(sendHelpButtonClickEvent).toHaveBeenCalledWith(
+      mockHref,
+      mockAnalyticsLabel
+    );
+  });
+});