Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: [UIE-8131] - IAM RBAC: Routes, Menu, Feature Flag #11310

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

aaleksee-akamai
Copy link
Contributor

@aaleksee-akamai aaleksee-akamai commented Nov 22, 2024

Description πŸ“

IAM RBAC - all routes, menu, feature flag

Changes πŸ”„

  • new menu item
  • new feature flag
  • routes for iam

Target release date πŸ—“οΈ

Dec 10, 2024 (dev)

Preview πŸ“·

Include a screenshot or screen recording of the change.

πŸ”’ Use the Mask Sensitive Data setting for security.

πŸ’‘ Use <video src="" /> tag when including recordings in table.

Before After
image
image

|

As an Author, I have considered πŸ€”

  • πŸ‘€ Doing a self review
  • ❔ Our contribution guidelines
  • 🀏 Splitting feature into small PRs
  • βž• Adding a changeset
  • πŸ§ͺ Providing/improving test coverage
  • πŸ” Removing all sensitive information from the code and PR description
  • 🚩 Using a feature flag to protect the release
  • πŸ‘£ Providing comprehensive reproduction steps
  • πŸ“‘ Providing or updating our documentation
  • πŸ•› Scheduling a pair reviewing session
  • πŸ“± Providing mobile support
  • β™Ώ Providing accessibility support

  • I have read and considered all applicable items listed above.

As an Author, before moving this PR from Draft to Open, I confirmed βœ…

  • All unit tests are passing
  • TypeScript compilation succeeded without errors
  • Code passes all linting rules

@aaleksee-akamai aaleksee-akamai requested a review from a team as a code owner November 22, 2024 14:43
@aaleksee-akamai aaleksee-akamai requested review from bnussman-akamai and cpathipa and removed request for a team November 22, 2024 14:43
@aaleksee-akamai aaleksee-akamai force-pushed the UIE-8131-iam-rbac-routes-menu branch 2 times, most recently from 3fb6fc4 to 7b7680c Compare November 22, 2024 14:51
Copy link

github-actions bot commented Nov 22, 2024

Coverage Report: βœ…
Base Coverage: 86.94%
Current Coverage: 86.95%

@linode-gh-bot
Copy link
Collaborator

Cloud Manager UI test results

πŸ”Ί 4 failing tests on test run #5 β†—οΈŽ

❌ Failingβœ… Passingβ†ͺ️ SkippedπŸ• Duration
4 Failing451 Passing2 Skipped120m 5s

Details

Failing Tests
SpecTest
❌machine-image-upload.spec.tsmachine image » uploads machine image, mock finish event
❌machine-image-upload.spec.tsmachine image » uploads machine image, mock upload canceled failed event
❌machine-image-upload.spec.tsmachine image » uploads machine image, mock failed to decompress failed event
❌machine-image-upload.spec.tsmachine image » uploads machine image, mock expired upload event

Troubleshooting

Use this command to re-run the failing tests:

yarn cy:run -s "cypress/e2e/core/images/machine-image-upload.spec.ts,cypress/e2e/core/images/machine-image-upload.spec.ts,cypress/e2e/core/images/machine-image-upload.spec.ts,cypress/e2e/core/images/machine-image-upload.spec.ts"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants