Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: [M3-8651] - Migrate Tabs to ui package #11320

Conversation

pmakode-akamai
Copy link
Contributor

@pmakode-akamai pmakode-akamai commented Nov 25, 2024

Description 📝

Move Tabs and associated components, story and tests to ui package

Changes 🔄

  • Move Tabs and associated components (SafeTabPanel, TabLinkList, TabList, TabPanel, TabPanels, Tab), story and tests to @linode/ui package
  • Update existing imports
  • Add MemoryRouter to ui package's testHelpers utilities Options type
  • Change Tab type to TabProps to avoid naming conflicts with the Tab component in the barrel index.ts file and other parts of the manager package.

Target release date 🗓️

N/A

How to test 🧪

  • Confirm all checks pass
  • Confirm all the necessary imports are updated
  • Confirm nothing on CM and Storybook breaks
    • Ensure everything works as expected wherever Tabs is used
    • Ensure we are not importing from @linode/ui in @linode/ui
    • Run rm -r packages/manager/node_modules/.cache + clear your browser cache before testing Storybook

As an Author, I have considered 🤔

  • 👀 Doing a self review
  • ❔ Our contribution guidelines
  • 🤏 Splitting feature into small PRs
  • ➕ Adding a changeset
  • 🧪 Providing/improving test coverage
  • 🔐 Removing all sensitive information from the code and PR description
  • 🚩 Using a feature flag to protect the release
  • 👣 Providing comprehensive reproduction steps
  • 📑 Providing or updating our documentation
  • 🕛 Scheduling a pair reviewing session
  • 📱 Providing mobile support
  • ♿ Providing accessibility support

  • I have read and considered all applicable items listed above.

As an Author, before moving this PR from Draft to Open, I confirmed ✅

  • All unit tests are passing
  • TypeScript compilation succeeded without errors
  • Code passes all linting rules

@pmakode-akamai pmakode-akamai self-assigned this Nov 25, 2024
@pmakode-akamai pmakode-akamai marked this pull request as ready for review November 25, 2024 14:51
@pmakode-akamai pmakode-akamai requested a review from a team as a code owner November 25, 2024 14:51
@pmakode-akamai pmakode-akamai requested review from bnussman-akamai and carrillo-erik and removed request for a team November 25, 2024 14:51
@pmakode-akamai pmakode-akamai marked this pull request as draft November 25, 2024 14:53
@linode-gh-bot
Copy link
Collaborator

Cloud Manager UI test results

🔺 2 failing tests on test run #2 ↗︎

❌ Failing✅ Passing↪️ Skipped🕐 Duration
2 Failing453 Passing2 Skipped105m 30s

Details

Failing Tests
SpecTest
machine-image-upload.spec.tsmachine image » uploads machine image, mock failed to decompress failed event
machine-image-upload.spec.tsmachine image » uploads machine image, mock expired upload event

Troubleshooting

Use this command to re-run the failing tests:

yarn cy:run -s "cypress/e2e/core/images/machine-image-upload.spec.ts,cypress/e2e/core/images/machine-image-upload.spec.ts"

@pmakode-akamai
Copy link
Contributor Author

pmakode-akamai commented Nov 26, 2024

We need to sort out external dependencies (like react-router-dom, react-router, MemoryRouter, etc) first before migrating this to ui package. So, keeping this PR in Draft

Copy link

This PR is stale because it has been open 15 days with no activity. Please attend to this PR or it will be closed in 5 days

@github-actions github-actions bot added the Stale label Dec 12, 2024
@github-actions github-actions bot closed this Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants