Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: [M3-8945] - Update yup from 0.32.9 to 1.4.0 #11324

Open
wants to merge 7 commits into
base: develop
Choose a base branch
from

Conversation

bnussman-akamai
Copy link
Member

@bnussman-akamai bnussman-akamai commented Nov 25, 2024

Description πŸ“

  • Updates our validation library yup to the latest available version πŸ“¦
  • This bring improved type-safety, faster type checking, and better .when(...) syntax ✨
  • This should unblock us from updating @hookform/resolvers
  • I mostly just followed this upgrade guide

Preview πŸ“·

Note

There should not be any UI changes

How to test πŸ§ͺ

  • Verify all automated tests pass βœ…
  • Check schemas for faulty/incorrect changes πŸ‘€

As an Author, I have considered πŸ€”

  • πŸ‘€ Doing a self review
  • ❔ Our contribution guidelines
  • 🀏 Splitting feature into small PRs
  • βž• Adding a changeset
  • πŸ§ͺ Providing/improving test coverage
  • πŸ” Removing all sensitive information from the code and PR description
  • 🚩 Using a feature flag to protect the release
  • πŸ‘£ Providing comprehensive reproduction steps
  • πŸ“‘ Providing or updating our documentation
  • πŸ•› Scheduling a pair reviewing session
  • πŸ“± Providing mobile support
  • β™Ώ Providing accessibility support

  • I have read and considered all applicable items listed above.

As an Author, before moving this PR from Draft to Open, I confirmed βœ…

  • All unit tests are passing
  • TypeScript compilation succeeded without errors
  • Code passes all linting rules

@bnussman-akamai bnussman-akamai added Dependencies Pull requests that update a dependency file @linode/validation Changes are made to the @linode/validation package labels Nov 25, 2024
@bnussman-akamai bnussman-akamai self-assigned this Nov 25, 2024
@bnussman-akamai bnussman-akamai marked this pull request as ready for review November 26, 2024 15:59
@bnussman-akamai bnussman-akamai requested review from a team as code owners November 26, 2024 15:59
@bnussman-akamai bnussman-akamai requested review from jdamore-linode, carrillo-erik and harsh-akamai and removed request for a team November 26, 2024 15:59
Copy link
Contributor

@jdamore-linode jdamore-linode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @bnussman-akamai! Double checked and confirmed that OBJ test is passing locally

Copy link

Coverage Report: βœ…
Base Coverage: 86.95%
Current Coverage: 86.95%

Copy link
Contributor

@jaalah-akamai jaalah-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ty πŸš€

@jaalah-akamai jaalah-akamai added the Approved Multiple approvals and ready to merge! label Nov 27, 2024
@linode-gh-bot
Copy link
Collaborator

Cloud Manager UI test results

πŸ”Ί 1 failing test on test run #7 β†—οΈŽ

❌ Failingβœ… Passingβ†ͺ️ SkippedπŸ• Duration
1 Failing461 Passing2 Skipped104m 36s

Details

Failing Tests
SpecTest
❌clone-linode.spec.tsclone linode » can clone a Linode from Linode details page

Troubleshooting

Use this command to re-run the failing tests:

yarn cy:run -s "cypress/e2e/core/linodes/clone-linode.spec.ts"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Approved Multiple approvals and ready to merge! Dependencies Pull requests that update a dependency file @linode/validation Changes are made to the @linode/validation package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants