test: [M3-6611] - Add new assertions for linode backup tests #11326
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AzureLatte
requested review from
jdamore-linode
and removed request for
a team
AzureLatte
changed the title
AzureLatte
requested review from
mjac0bs and
pmakode-akamai
and removed request for
a team
|
Coverage Report: ✅ |
Cloud Manager UI test results🔺 3 failing tests on test run #2 ↗︎
Details
TroubleshootingUse this command to re-run the failing tests: yarn cy:run -s "cypress/e2e/core/images/machine-image-upload.spec.ts,cypress/e2e/core/linodes/linode-storage.spec.ts,cypress/e2e/core/linodes/linode-storage.spec.ts" |
|||||||||||||||||||||||
jdamore-linode
approved these changes
Nov 25, 2024
There was a problem hiding this comment.
Clean! 🧼 Thanks Azure!
Edit: You're welcome to disregard the test failures but I think all of those are fixed in develop now -- shout out to @bnussman-akamai for the machine images fixes!
mjac0bs
approved these changes
Nov 25, 2024
| "@linode/manager": Tests | ||
| --- | ||
|
|
||
| Add new assertions for linode backup tests ([#11326](https://github.com/linode/manager/pull/11326)) |
There was a problem hiding this comment.
Suggested change
| Add new assertions for linode backup tests ([#11326](https://github.com/linode/manager/pull/11326)) | |
| Add new assertions for linode backup Cypress tests ([#11326](https://github.com/linode/manager/pull/11326)) |
Optional nit for clarity
mjac0bs
added
Approved
pmakode-akamai
approved these changes
Nov 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description 📝
The cypress/e2e/core/linodes/backup-linode.spec.ts have a few shortcomings that should be addressed:
Changes 🔄
List any change(s) relevant to the reviewer.
How to test 🧪
As an Author, I have considered 🤔