tech-story: [M3-8940] - Dev Tools fixes and improvements #11328
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abailly-akamai
changed the title
abailly-akamai
requested review from
coliu-akamai,
pmakode-akamai and
jaalah-akamai
and removed request for
a team
abailly-akamai
commented
Nov 26, 2024
| 'VPCs', | ||
| ] as const; | ||
|
|
||
| export type AccountCapability = typeof accountCapabilities[number]; |
There was a problem hiding this comment.
This changes nothing to the types, just allows to export the values
| </details> | ||
| </ul> | ||
| ); | ||
| }; |
There was a problem hiding this comment.
Allowing recursiveness so the JSON flag can be as deep as needed and represented here
Left to do: handle the cases for when a flag is something else than a boolean, which we rarely do
|
|
||
| const FieldWrapper = ({ children }: { children: React.ReactNode }) => { | ||
| return <div className="dev-tools__modal-form__field">{children}</div>; | ||
| }; |
There was a problem hiding this comment.
Before we were only providing a static factory override. This updates allows much more flexibility for both the response.
abailly-akamai
force-pushed
the
M3-8940
branch
from
632447c
to
674f537
Compare
abailly-akamai
force-pushed
the
M3-8940
branch
from
674f537
to
86d2c60
Compare
|
Coverage Report: ✅ |
Cloud Manager UI test results🔺 1 failing test on test run #6 ↗︎
Details
TroubleshootingUse this command to re-run the failing tests: yarn cy:run -s "cypress/e2e/core/billing/smoke-billing-activity.spec.ts" |
|||||||||||||||||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description 📝
Long overdue updates to our beloved Dev Tools. This PR does not touch any client code. Brings a lot of improvements and fixes to presets and mocking.
Note
Code quality/readability/reusability is not as high as it would be for client code, tho I tried best to achieve that while working quickly. The goal aims to help the developer experience first 💨
Changes 🔄
Target release date 🗓️
Please specify a release date (and environment, if applicable) to guarantee timely review of this PR. If exact date is not known, please approximate and update it as needed.
Preview 📷
How to test 🧪
Verification steps
As an Author, I have considered 🤔
👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support
I have read and considered all applicable items listed above.
As an Author, before moving this PR from Draft to Open, I confirmed ✅