-
Notifications
You must be signed in to change notification settings - Fork 363
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
upcoming: [M3-8848] - Update Kubernetes version Autocomplete to filter on LKE-E versions #11359
base: develop
Are you sure you want to change the base?
Changes from all commits
9c92a6b
b9732d4
7525fee
87f8b1d
7546d04
b840b1d
fd38894
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
--- | ||
"@linode/manager": Upcoming Features | ||
--- | ||
|
||
Update Kubernetes Versions in Create Cluster flow to support tiers for LKE-E ([#11359](https://github.com/linode/manager/pull/11359)) |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -14,6 +14,7 @@ import { | |
mockGetCluster, | ||
mockCreateClusterError, | ||
mockGetControlPlaneACL, | ||
mockGetTieredKubernetesVersions, | ||
} from 'support/intercepts/lke'; | ||
import { mockGetAccount } from 'support/intercepts/account'; | ||
import { | ||
|
@@ -22,7 +23,10 @@ import { | |
} from 'support/intercepts/regions'; | ||
import { KubernetesCluster } from '@linode/api-v4'; | ||
import { LkePlanDescription } from 'support/api/lke'; | ||
import { lkeClusterPlans } from 'support/constants/lke'; | ||
import { | ||
latestEnterpriseTierKubernetesVersion, | ||
lkeClusterPlans, | ||
} from 'support/constants/lke'; | ||
import { chooseRegion, getRegionById } from 'support/util/regions'; | ||
import { interceptCreateCluster } from 'support/intercepts/lke'; | ||
import { ui } from 'support/ui'; | ||
|
@@ -870,8 +874,12 @@ describe('LKE Cluster Creation with LKE-E', () => { | |
capabilities: ['Kubernetes Enterprise'], | ||
}) | ||
).as('getAccount'); | ||
mockGetTieredKubernetesVersions('enterprise', [ | ||
latestEnterpriseTierKubernetesVersion, | ||
]).as('getTieredKubernetesVersions'); | ||
|
||
cy.visitWithLogin('/kubernetes/clusters'); | ||
cy.wait(['@getAccount']); | ||
|
||
ui.button | ||
.findByTitle('Create Cluster') | ||
|
@@ -880,6 +888,7 @@ describe('LKE Cluster Creation with LKE-E', () => { | |
.click(); | ||
|
||
cy.url().should('endWith', '/kubernetes/create'); | ||
cy.wait(['@getTieredKubernetesVersions']); | ||
|
||
cy.findByText('Cluster Type').should('be.visible'); | ||
|
||
|
@@ -904,6 +913,18 @@ describe('LKE Cluster Creation with LKE-E', () => { | |
// Confirm HA section is hidden since LKE-E includes HA by default | ||
cy.findByText('HA Control Plane').should('not.exist'); | ||
|
||
// Selects an enterprise version | ||
ui.autocomplete | ||
.findByLabel('Kubernetes Version') | ||
.should('be.visible') | ||
.click(); | ||
|
||
ui.autocompletePopper | ||
.findByTitle(latestEnterpriseTierKubernetesVersion.id) | ||
.should('be.visible') | ||
.should('be.enabled') | ||
.click(); | ||
Comment on lines
+916
to
+926
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I'm getting intermittent* failures here where the In each case I've observed, Cloud is making the expected GET request to Hoping to spend more time looking at this, but wanted to give you a heads up in the meantime!
lke-create.spec.ts.mp4 |
||
|
||
// TODO: finish the rest of this test in subsequent PRs | ||
}); | ||
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if there'd be any benefit to mocking the
standard
versions response so Cloud doesn't try to send repeated requests to that endpoint during the test?It doesn't seem to make a difference when it comes to the test failure I mentioned, though π