Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change: [M3-8961] - Change Pendo sanitized url path string to match UXR request #11361

Merged

Conversation

mjac0bs
Copy link
Contributor

@mjac0bs mjac0bs commented Dec 3, 2024

Description 📝

UXR has reported:

"On our end, to ensure we are tracking accurately, we have to replace the XXXX with an <ignore> or * rule in the Pendo Tagging tool. Is there a way to replace it with a *? It will save manual steps in Pendo.. . once most pages have those bits replaced while retrotagging, we can make sure to look out for XXXX and replaced it in the Rule Builder with the attached screenshots."

Even with rules configured, changing the XXXX to * now will save time and speed up the tagging process in the future because new URLs will not have to have the same rules configured to transform the XXXXs.

Note: We confirmed via Pendo that the unicode %2A wouldn't be an issue - the * in a rule will match the unicode in the normalized pattern.

Changes 🔄

  • Replaced the XXXX string with * in URL transformation and unit test

Target release date 🗓️

12/10

Preview 📷

Before After
Screenshot 2024-12-03 at 10 20 29 AM image (9)
Screenshot 2024-12-03 at 10 21 28 AM Screenshot 2024-12-03 at 10 38 00 AM

How to test 🧪

Prerequisites

(How to setup test environment)

Verification steps

(How to verify changes)

  • Confirm the change looking at the normalizedUrl in requests in the browser console filtering on "pendo".
  • Confirm unit test passes:
yarn test usePendo
Author Checklists

As an Author, to speed up the review process, I considered 🤔

👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support


  • I have read and considered all applicable items listed above.

As an Author, before moving this PR from Draft to Open, I confirmed ✅

  • All unit tests are passing
  • TypeScript compilation succeeded without errors
  • Code passes all linting rules

@mjac0bs mjac0bs added Work in Progress Analytics Relating to Analytics migration project or Adobe Analytics labels Dec 3, 2024
@mjac0bs mjac0bs self-assigned this Dec 3, 2024
@mjac0bs mjac0bs marked this pull request as ready for review December 4, 2024 16:40
@mjac0bs mjac0bs requested a review from a team as a code owner December 4, 2024 16:40
@mjac0bs mjac0bs requested review from carrillo-erik and hkhalil-akamai and removed request for a team December 4, 2024 16:40
@mjac0bs mjac0bs force-pushed the M3-8961-adjust-pendo-url-path-sanitization branch from c2e805f to fb2ae7f Compare December 4, 2024 16:42
Copy link
Contributor

@coliu-akamai coliu-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ unit tests pass
✅ confirmed pendo urls now showing the %2A

thank you!

Copy link

github-actions bot commented Dec 4, 2024

Coverage Report:
Base Coverage: 86.85%
Current Coverage: 86.85%

@mjac0bs mjac0bs added the Add'tl Approval Needed Waiting on another approval! label Dec 4, 2024
@linode-gh-bot
Copy link
Collaborator

Cloud Manager UI test results

🔺 1 failing test on test run #2 ↗︎

❌ Failing✅ Passing↪️ Skipped🕐 Duration
1 Failing464 Passing2 Skipped93m 50s

Details

Failing Tests
SpecTest
linode-config.spec.tsEnd-to-End » Clones a config

Troubleshooting

Use this command to re-run the failing tests:

yarn cy:run -s "cypress/e2e/core/linodes/linode-config.spec.ts"

@bnussman-akamai bnussman-akamai added Approved Multiple approvals and ready to merge! and removed Add'tl Approval Needed Waiting on another approval! labels Dec 4, 2024
@mjac0bs mjac0bs merged commit 6ff1863 into linode:develop Dec 4, 2024
22 of 23 checks passed
Copy link
Contributor

@dwiley-akamai dwiley-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test for usePendo passes ✅
Sanitized URL path confirmed ✅

Screenshot 2024-12-04 at 1 29 27 PM

Copy link

cypress bot commented Dec 4, 2024

Cloud Manager E2E    Run #6918

Run Properties:  status check failed Failed #6918  •  git commit 6ff186372b: change: [M3-8961] - Change Pendo sanitized url path string to match UXR request ...
Project Cloud Manager E2E
Branch Review develop
Run status status check failed Failed #6918
Run duration 34m 37s
Commit git commit 6ff186372b: change: [M3-8961] - Change Pendo sanitized url path string to match UXR request ...
Committer Mariah Jacobs
View all properties for this run ↗︎

Test results
Tests that failed  Failures 3
Tests that were flaky  Flaky 1
Tests that did not run due to a developer annotating a test with .skip  Pending 2
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 462
View all changes introduced in this branch ↗︎

Tests for review

Failed  linode-config.spec.ts • 1 failed test

View Output Video

Test Artifacts
Linode Config management > End-to-End > Clones a config Screenshots Video
Failed  rebuild-linode.spec.ts • 1 failed test

View Output Video

Test Artifacts
rebuild linode > rebuilds a linode from Account StackScript Screenshots Video
Failed  clone-linode.spec.ts • 1 failed test

View Output Video

Test Artifacts
clone linode > can clone a Linode from Linode details page Screenshots Video
Flakiness  cypress/e2e/core/firewalls/migrate-linode-with-firewall.spec.ts • 1 flaky test

View Output Video

Test Artifacts
Migrate Linode With Firewall > migrates linode with firewall - real data Screenshots Video

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Analytics Relating to Analytics migration project or Adobe Analytics Approved Multiple approvals and ready to merge!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants