-
Notifications
You must be signed in to change notification settings - Fork 363
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
change: [M3-8961] - Change Pendo sanitized url path string to match UXR request #11361
change: [M3-8961] - Change Pendo sanitized url path string to match UXR request #11361
Conversation
c2e805f
to
fb2ae7f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✅ unit tests pass
✅ confirmed pendo urls now showing the %2A
thank you!
Coverage Report: ✅ |
Cloud Manager UI test results🔺 1 failing test on test run #2 ↗︎
Details
TroubleshootingUse this command to re-run the failing tests: yarn cy:run -s "cypress/e2e/core/linodes/linode-config.spec.ts" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cloud Manager E2E Run #6918
Run Properties:
|
Project |
Cloud Manager E2E
|
Branch Review |
develop
|
Run status |
Failed #6918
|
Run duration | 34m 37s |
Commit |
6ff186372b: change: [M3-8961] - Change Pendo sanitized url path string to match UXR request ...
|
Committer | Mariah Jacobs |
View all properties for this run ↗︎ |
Test results | |
---|---|
Failures |
3
|
Flaky |
1
|
Pending |
2
|
Skipped |
0
|
Passing |
462
|
View all changes introduced in this branch ↗︎ |
Tests for review
linode-config.spec.ts • 1 failed test
Test | Artifacts | |
---|---|---|
Linode Config management > End-to-End > Clones a config |
Screenshots
Video
|
rebuild-linode.spec.ts • 1 failed test
Test | Artifacts | |
---|---|---|
rebuild linode > rebuilds a linode from Account StackScript |
Screenshots
Video
|
clone-linode.spec.ts • 1 failed test
Test | Artifacts | |
---|---|---|
clone linode > can clone a Linode from Linode details page |
Screenshots
Video
|
cypress/e2e/core/firewalls/migrate-linode-with-firewall.spec.ts • 1 flaky test
Test | Artifacts | |
---|---|---|
Migrate Linode With Firewall > migrates linode with firewall - real data |
Screenshots
Video
|
Description 📝
UXR has reported:
"On our end, to ensure we are tracking accurately, we have to replace the
XXXX
with an<ignore>
or*
rule in the Pendo Tagging tool. Is there a way to replace it with a*
? It will save manual steps in Pendo.. . once most pages have those bits replaced while retrotagging, we can make sure to look out forXXXX
and replaced it in the Rule Builder with the attached screenshots."Even with rules configured, changing the
XXXX
to*
now will save time and speed up the tagging process in the future because new URLs will not have to have the same rules configured to transform theXXXX
s.Note: We confirmed via Pendo that the unicode %2A wouldn't be an issue - the * in a rule will match the unicode in the normalized pattern.
Changes 🔄
XXXX
string with*
in URL transformation and unit testTarget release date 🗓️
12/10
Preview 📷
How to test 🧪
Prerequisites
(How to setup test environment)
Verification steps
(How to verify changes)
Author Checklists
As an Author, to speed up the review process, I considered 🤔
👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support
As an Author, before moving this PR from Draft to Open, I confirmed ✅