-
Notifications
You must be signed in to change notification settings - Fork 364
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[M3-8991 + M3-6911] - Select Components + Managed Replacement #11391
Draft
abailly-akamai
wants to merge
17
commits into
linode:develop
Choose a base branch
from
abailly-akamai:M3-6911
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abailly-akamai
changed the title
[M3-6911] - Select Components + Managed Replacement
[M3-6911 & M3-8991] - Select Components + Managed Replacement
Dec 10, 2024
abailly-akamai
changed the title
[M3-6911 & M3-8991] - Select Components + Managed Replacement
[M3-8991 + M3-6911] - Select Components + Managed Replacement
Dec 10, 2024
abailly-akamai
force-pushed
the
M3-6911
branch
from
December 11, 2024 18:29
48b087c
to
c9e9b45
Compare
Cloud Manager UI test resultsπ 469 passing tests on test run #7 βοΈ
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description π
Highlight the Pull Request's context and intentions.
Changes π
List any change(s) relevant to the reviewer.
Target release date ποΈ
Please specify a release date (and environment, if applicable) to guarantee timely review of this PR. If exact date is not known, please approximate and update it as needed.
Preview π·
Include a screenshot or screen recording of the change.
π Use the Mask Sensitive Data setting for security.
π‘ Use
<video src="" />
tag when including recordings in table.How to test π§ͺ
Prerequisites
(How to setup test environment)
Reproduction steps
(How to reproduce the issue, if applicable)
Verification steps
(How to verify changes)
Author Checklists
As an Author, to speed up the review process, I considered π€
π Doing a self review
β Our contribution guidelines
π€ Splitting feature into small PRs
β Adding a changeset
π§ͺ Providing/improving test coverage
π Removing all sensitive information from the code and PR description
π© Using a feature flag to protect the release
π£ Providing comprehensive reproduction steps
π Providing or updating our documentation
π Scheduling a pair reviewing session
π± Providing mobile support
βΏ Providing accessibility support
As an Author, before moving this PR from Draft to Open, I confirmed β
Commit message and pull request title format standards
<commit type>: [JIRA-ticket-number] - <description>
Commit Types:
feat
: New feature for the user (not a part of the code, or ci, ...).fix
: Bugfix for the user (not a fix to build something, ...).change
: Modifying an existing visual UI instance. Such as a component or a feature.refactor
: Restructuring existing code without changing its external behavior or visual UI. Typically to improve readability, maintainability, and performance.test
: New tests or changes to existing tests. Does not change the production code.upcoming
: A new feature that is in progress, not visible to users yet, and usually behind a feature flag.Example:
feat: [M3-1234] - Allow user to view their login history