Support upgrade attribute for DC migration #1639
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zliang-akamai
requested review from
ykim-akamai and
yec-akamai
and removed request for
a team
zliang-akamai
commented
Oct 31, 2024
| github.com/linode/linodego v1.42.0 | ||
| github.com/linode/linodego v1.42.1-0.20241031190843-e69c3138ddcf |
There was a problem hiding this comment.
We will need to wait for the next linodego release for this PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
This is to support
upgradeattribute for DC migration for Linode instances.✔️ How to Test
Automated Testing
make int-test PKG_NAME="linode/instance"It's hard to simulate upgrading in integration testing because we don't have a newer type than g6.
Manual Testing
I couldn't find a way to test it because I couldn't create a old Linode plan with a pending upgrade. Any suggestion?