Add add_vpcs and add_placement_groups user grants #1720
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stvnjacobs
requested review from
ykim-akamai and
yec-akamai
and removed request for
a team
stvnjacobs
commented
Jan 15, 2025
| resource.TestCheckResourceAttr(testUserResName, "global_grants.0.add_stackscripts", "false"), | ||
| resource.TestCheckResourceAttr(testUserResName, "global_grants.0.add_volumes", "false"), | ||
| resource.TestCheckResourceAttr(testUserResName, "global_grants.0.add_vpcs", "false"), |
There was a problem hiding this comment.
This file is what give me the most uncertainty. I confess to not digging to far into how it worked and just chose "false" in both cases.
stvnjacobs
force-pushed
the
feat/user-grants-pg-vpc
branch
from
255f74d to
98f08dc
Compare
linodego added support for the `add_vpcs` and `add_placement_group` user grants in v1.44.0 (linode/linodego#622). This patch adds support for these fields in the `linode_user` resource.
stvnjacobs
force-pushed
the
feat/user-grants-pg-vpc
branch
from
98f08dc to
975aadf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
linodego added support for the
add_vpcsandadd_placement_groupuser grants in v1.44.0 (linode/linodego#622). At the time of writing, terraform-provider-linode is on [email protected]. This patch adds support for these fields in thelinode_userresource.✔️ How to Test
I have run
make, andmake unit-tests, but not run the integration tests. I believe all tests cases were updated, as I followed the same pattern used in other grants.