feat: Improve validation performance #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit improves validation performance by changing the parallelism model to a bag-of-tasks where the number of workers is equal to the number of system threads. This reduces the overhead of switching between potentially thousands of threads.
|
Does this ensure that every thread gets a different file to check? And if a check fails, do all other checks also get cancelled (if the quit on fail option is enabled) |
Each line of the filelist gets passed to a shared channel, where only one thread can pick a line.
I forgot to re-introduce this option. I'll work on a fix. |
mirkobrombin
approved these changes
Feb 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves validation performance by changing the parallelism model to a bag-of-tasks where the number of workers is equal to the number of system threads. This reduces the overhead of switching between potentially thousands of threads.