Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

infiniband-diags: use correct port info to get cap_mask for ibnd_get_agg_linkspeedextsup #1555

Merged
merged 1 commit into from
Feb 4, 2025

Conversation

mazorasaf
Copy link
Contributor

@mazorasaf mazorasaf commented Jan 29, 2025

Added get_port_info_for_cap_mask to retrieve the correct port information for determining the cap_mask -
in the case of a Switch we should be using port 0, In other cases it should be the current port.
This function is now utilized with the ibnd_get_agg_linkspeedext methods in ibdiag_common to ensure accurate handling.

@mazorasaf mazorasaf force-pushed the fix_iblinkinfo_incorrect_text branch 2 times, most recently from 3672384 to a848444 Compare January 30, 2025 15:52
@rleon
Copy link
Member

rleon commented Feb 2, 2025

Same comment as in previous PR.
In addition, parent and issue are not relevant here.

@mazorasaf mazorasaf force-pushed the fix_iblinkinfo_incorrect_text branch from a848444 to a5ce59e Compare February 2, 2025 11:07
@rleon
Copy link
Member

rleon commented Feb 4, 2025

  1. You have extra blank line between Fixes and SOB lines.
  2. Fixes should have 12 chars and not 7
  3. Please double check your commit message, it lacks punctuation and sentences are not complete.

@mazorasaf mazorasaf force-pushed the fix_iblinkinfo_incorrect_text branch from a5ce59e to f7338a7 Compare February 4, 2025 09:32
Added get_port_info_for_cap_mask to retrieve the correct port information for determining the cap_mask -
in the case of a Switch we should be using port 0, In other cases it should be the current port.
This function is now utilized with the ibnd_get_agg_linkspeedext methods in ibdiag_common to ensure accurate handling.

Fixes: d01b21b ("ibnetdisc: Adding support XDR speed and collect aggregated values of LinkSpeedExt & LinkSpeedExt2 groups field")
Signed-off-by: Asaf Mazor <[email protected]>
@mazorasaf mazorasaf force-pushed the fix_iblinkinfo_incorrect_text branch from f7338a7 to e62f0ae Compare February 4, 2025 10:46
@rleon rleon merged commit a4eaf22 into linux-rdma:master Feb 4, 2025
6 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants