RDMA FLUSH and ATOMIC WRITE with ODP #1580
Conversation
|
The kernel-side enablement was merged to for-next. |
| @@ -235,6 +235,8 @@ enum ibv_odp_transport_cap_bits { | |||
| IBV_ODP_SUPPORT_READ = 1 << 3, | |||
| IBV_ODP_SUPPORT_ATOMIC = 1 << 4, | |||
| IBV_ODP_SUPPORT_SRQ_RECV = 1 << 5, | |||
| IBV_ODP_SUPPORT_FLUSH = 1 << 6, | |||
There was a problem hiding this comment.
Why aren't these bits coming from UAPI?
There was a problem hiding this comment.
Okay. I will send a kernel patch to add IB_UVERBS_ODP_* flags in include/uapi/rdma/ib_user_verbs.h and update this PR accordingly.
There was a problem hiding this comment.
@rleon
I've submitted the kernel patch and updated this PR.
Thanks
There was a problem hiding this comment.
I revised the kernel-headers commit after all the kernel-side patches were merged.
|
General comment to all patches. Please write commit messages for all commits. Thanks |
To commit: 685f9537a728 ("RDMA/core: Move ODP capability definitions to
uapi").
Signed-off-by: Daisuke Matsuda <[email protected]>
ddmatsu
force-pushed
the
odp-extended
branch
3 times, most recently
from
60bb335 to
765c81e
Compare
|
CI must pass for this PR |
ddmatsu
force-pushed
the
odp-extended
branch
2 times, most recently
from
2033412 to
bbd0dc9
Compare
Add ODP capabilities for RDMA FLUSH and ATOMIC WRITE so that the flags can be queried via ibv_query_device_ex(). Signed-off-by: Daisuke Matsuda <[email protected]>
Let pyverbs use the new bits for ODP capabilities. Signed-off-by: Daisuke Matsuda <[email protected]>
Add a test of ATOMIC WRITE sequences with ODP. MR is invalidated at the beginning of this workload so that page fault is triggered at least once. The test was implemented in reference to test_qp_ex_rc_atomic_write() in test_qpex.py. create_qp_ex() is moved to utils.py so that it can be used from other tests. Signed-off-by: Daisuke Matsuda <[email protected]>
Add a test of RDMA FLUSH sequences with ODP. MR is invalidated at the beginning of this workload so that page fault is triggered at least once. The test was implemented in reference to test_qp_ex_rc_flush() in test_qpex.py Signed-off-by: Daisuke Matsuda <[email protected]>
|
I think it is now okay. |
RDMA FLUSH[1] and ATOMIC WRITE[2] were added to rxe, but they cannot run
in the ODP mode as of now. This series is for the userspace enablement.
The former three patches correspond to an uapi change in the kernel.
(v1/merged) https://lore.kernel.org/linux-rdma/[email protected]/T/#t
The latter four add definitions of ODP capabilities and rdma-core testcases for the new features.
For kernel-side enablement in rxe, please see:
(Updated v3/merged) https://lore.kernel.org/linux-rdma/[email protected]/T/#t
[1] [for-next PATCH 00/10] RDMA/rxe: Add RDMA FLUSH operation
https://lore.kernel.org/lkml/[email protected]/
[2] [PATCH v7 0/8] RDMA/rxe: Add atomic write operation
https://lore.kernel.org/linux-rdma/[email protected]/