ci: Add ALP-Dolomite var file #141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richm
reviewed
Jan 5, 2024
tasks/setup-zypper.yml
Outdated
| reboot: | ||
| when: ansible_distribution == 'ALP-Dolomite' | ||
|
|
||
| - name: Flush handlers |
There was a problem hiding this comment.
If you reboot the system, do you still need to run the handlers?
# handlers file for cockpit
- name: Reload systemd
systemd:
daemon_reload: true
- name: Restart cockpit
service:
name: "{{ __cockpit_daemon }}"
# noqa args[module]
state: "{{ 'restarted' if cockpit_started | bool else 'stopped' }}"
not sure how ALP-Dolomite works - it will not perform these actions upon reboot?
There was a problem hiding this comment.
A reboot is required after installing new packages due to the use of transactional updates, the 'Flush handlers' task is redundant I'll update the changes
richm
reviewed
Jan 6, 2024
tasks/setup-zypper.yml
Outdated
| when: cockpit_packages is defined | ||
|
|
||
| - name: Ensure Cockpit Web Console packages are installed. | ||
| zypper: |
There was a problem hiding this comment.
Suggested change
| zypper: | |
| community.general.zypper: |
Also - change meta/collection-requirements.yml to look like this:
# SPDX-License-Identifier: MIT
---
collections:
- ansible.posix
- community.general
- fedora.linux_system_rolesThat should make linters and ansible-plugin-scan happy
There was a problem hiding this comment.
Thank you for the suggestion, @richm . I have updated the meta/collection-requirements.yml as advised and made the necessary changes to the zypper reference
richm
approved these changes
Jan 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enhancement: This pull request adds the
ALP-Dolomite.ymlvariable file and setup-zypper.yml to support SUSE ALP-Dolomite configurations.Reason: The existing configuration does not cover SUSE ALP.
Result: Works as expected in the added operating system.
Issue Tracker Tickets (Jira or BZ if any):na