Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: support for qdevice tls and kaptb options #153

Merged
merged 3 commits into from
Oct 11, 2023
Merged

Conversation

tomjelinek
Copy link
Member

@tomjelinek tomjelinek commented Oct 6, 2023

Support for these options is purely a pcs thing, there is no code update needed to be done in the role itself. This test demonstrates that the options are indeed supported by the role.

Issue Tracker Tickets (Jira or BZ if any):
RHEL-3264
RHEL-7745

@tomjelinek tomjelinek requested a review from richm as a code owner October 6, 2023 14:58
@codecov
Copy link

codecov bot commented Oct 6, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (a2537d0) 80.45% compared to head (901e9ae) 80.45%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #153   +/-   ##
=======================================
  Coverage   80.45%   80.45%           
=======================================
  Files           3        3           
  Lines         133      133           
=======================================
  Hits          107      107           
  Misses         26       26           
Flag Coverage Δ
sanity ∅ <ø> (∅)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tomjelinek tomjelinek changed the title support for qdevice tls and kaptb options test: support for qdevice tls and kaptb options Oct 6, 2023
@tomjelinek
Copy link
Member Author

[citest]

Support for these options is purely a pcs thing, there is no code update
needed to be done in the role itself. This test demonstrates that the
options are indeed supported by the role.
@tomjelinek
Copy link
Member Author

[citest]

@richm
Copy link
Contributor

richm commented Oct 10, 2023

I guess the output of pcs property on Fedora is different than EL? Uses = instead of : for delimiter?

TASK [Fetch cluster properties configuration from the cluster] *****************
task path: /WORKDIR/git-qdevice-optionsqr4xvofg/tests/tests_cib_properties_one_set.yml:39
Tuesday 10 October 2023  08:10:04 +0000 (0:00:00.081)       0:02:56.282 ******* 
ok: [sut] => {
    "changed": false,
    "cmd": [
        "pcs",
        "property"
    ],
    "delta": "0:00:00.675503",
    "end": "2023-10-10 08:10:05.454936",
    "rc": 0,
    "start": "2023-10-10 08:10:04.779433"
}

STDOUT:

Cluster Properties: cib-bootstrap-options
  cluster-infrastructure=corosync
  cluster-name=test-cluster
  dc-version=2.1.6-4.fc37-6fdc9deea29
  have-watchdog=false
  no-quorum-policy=stop
  stonith-enabled=true
  stonith-watchdog-timeout=0
...

TASK [Check cluster properties configuration] **********************************
task path: /WORKDIR/git-qdevice-optionsqr4xvofg/tests/tests_cib_properties_one_set.yml:49
Tuesday 10 October 2023  08:10:05 +0000 (0:00:00.047)       0:02:57.259 ******* 
fatal: [sut]: FAILED! => {
    "assertion": "'no-quorum-policy: stop' in stdout_lines",
    "changed": false,
    "evaluated_to": false
}

MSG:

Assertion failed

@tomjelinek
Copy link
Member Author

I guess the output of pcs property on Fedora is different than EL? Uses = instead of : for delimiter?

I'm already working on it. It looks like pcs has been updated on Fedora and a condition in the test doesn't take it into account.

@tomjelinek
Copy link
Member Author

[citest]

@tomjelinek tomjelinek merged commit 8127e08 into main Oct 11, 2023
21 checks passed
@tomjelinek tomjelinek deleted the qdevice-options branch October 11, 2023 07:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants