fix: make consistent approach for multiple node attributes sets #201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, pcs does not support multiple nvsets and system role must deal with it. The case of multiple nvsets in node attributes was handled differently than multiple nvsets in other cases. This fix makes dealing with node attributes consitent with the rest. Also in README.md is now explicitly mentioned, that (in the cases of multiple nvsets) only the first set is used and the rest are ignored.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #201 +/- ##
=======================================
Coverage 68.50% 68.50%
=======================================
Files 3 3
Lines 181 181
=======================================
Hits 124 124
Misses 57 57 ☔ View full report in Codecov by Sentry. |
richm
reviewed
Apr 17, 2024
|
[citest] |
tomjelinek
approved these changes
Apr 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enhancement:
Handle node attributes with multiple attributes sets consistently with rest of the role.
Reason:
Node attributes multiple sets was handled in a manner inconsistent with the rest of the role. Instead of using only the first set and ignoring the rest, multiple sets was merged into one single set. Such inconsistency can confuse a user and may complicate the possible future addition of support for multiple sets.
Result:
Node attributes multiple set are handled consistently with the rest of the role. This behavior is also described more explicitly in README.md.
Issue Tracker Tickets (Jira or BZ if any):
https://issues.redhat.com/browse/RHEL-33076