Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: tox-lsr 3.4.0 - fix py27 tests; move other checks to py310 #207

Merged
merged 3 commits into from
Jun 4, 2024

Conversation

richm
Copy link
Contributor

@richm richm commented Jun 3, 2024

The latest version of virtualenv does not support creating
python 2.7 virtualenvs. Change our CI tests to restrict the version
of virtualenv<20.22.0 and tox<4.15 for py27 environments

Move pylint, flake8, and black checks to the py310 environment
which is currently supported by ansible-core 2.17 and its related
checkers such as ansible-lint and ansible-test

pylint now uses ansible-core 2.17 and restricts the version of
pylint to 3.1.0 which is the version used by ansible-test 2.17

Remove extends: default for .yamllint.yml. The latest version
of ansible-lint will automatically incorporate local yamllint
settings unless there is an extends:.

The above changes require some fixes to the role code.

For more information, see
linux-system-roles/tox-lsr#168
and
linux-system-roles/tox-lsr#170

Signed-off-by: Rich Megginson [email protected]

The latest version of virtualenv does not support creating
python 2.7 virtualenvs.  Change our CI tests to restrict the version
of virtualenv<20.22.0 and tox<4.15 for py27 environments

Move pylint, flake8, and black checks to the py310 environment
which is currently supported by ansible-core 2.17 and its related
checkers such as ansible-lint and ansible-test

pylint now uses ansible-core 2.17 and restricts the version of
pylint to 3.1.0 which is the version used by ansible-test 2.17

Remove `extends: default` for .yamllint.yml.  The latest version
of ansible-lint will automatically incorporate local yamllint
settings unless there is an `extends:`.

The above changes require some fixes to the role code.

For more information, see
linux-system-roles/tox-lsr#168
and
linux-system-roles/tox-lsr#170

Signed-off-by: Rich Megginson <[email protected]>
@richm richm requested a review from tomjelinek as a code owner June 3, 2024 16:27
@tomjelinek
Copy link
Member

In pyproject.toml, black is configured for line-length of 80 characters. Apparently, your environment ignores that and makes the lines longer.

Ad pylint: disable=import-error: if pylint is unable to import the modules, does it even check the module's functions are used correctly? I don't need this ignore in my environment. What issues is it working around?

@richm
Copy link
Contributor Author

richm commented Jun 4, 2024

In pyproject.toml, black is configured for line-length of 80 characters. Apparently, your environment ignores that and makes the lines longer.

Ad pylint: disable=import-error: if pylint is unable to import the modules, does it even check the module's functions are used correctly? I don't need this ignore in my environment. What issues is it working around?

I think I found a better way to fix these - see the latest commit

@tomjelinek
Copy link
Member

In pyproject.toml, black is configured for line-length of 80 characters. Apparently, your environment ignores that and makes the lines longer.
Ad pylint: disable=import-error: if pylint is unable to import the modules, does it even check the module's functions are used correctly? I don't need this ignore in my environment. What issues is it working around?

I think I found a better way to fix these - see the latest commit

Perfect, thank you!

@richm richm merged commit fa56bac into main Jun 4, 2024
19 checks passed
@richm richm deleted the tox-lsr-3.4.0 branch June 4, 2024 23:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants