Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: improve name text for skipped ostree tests #684

Merged
merged 1 commit into from
Mar 25, 2024

Conversation

richm
Copy link
Contributor

@richm richm commented Mar 17, 2024

Improve the name text for skipped ostree tests to explain
why the test is skipped.

Signed-off-by: Rich Megginson [email protected]

@richm richm requested a review from liangwen12year as a code owner March 17, 2024 20:39
@richm richm requested a review from tyll March 17, 2024 20:39
Copy link

codecov bot commented Mar 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 45.00%. Comparing base (44f937d) to head (ea3c40c).

Additional details and impacted files
@@             Coverage Diff             @@
##             main     #684       +/-   ##
===========================================
+ Coverage   20.50%   45.00%   +24.49%     
===========================================
  Files          10       12        +2     
  Lines        1478     3100     +1622     
  Branches      433      433               
===========================================
+ Hits          303     1395     +1092     
- Misses       1174     1704      +530     
  Partials        1        1               
Flag Coverage Δ
sanity 20.50% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@liangwen12year liangwen12year added the Wait_Submitter The submitter needs to do something before this can move on label Mar 20, 2024
@liangwen12year
Copy link
Collaborator

liangwen12year commented Mar 25, 2024

Can you also use the include_tasks: ostree_systems_check.yml in playbooks/tests_wireless_and_network_restart.yml?

@liangwen12year
Copy link
Collaborator

[citest]

Improve the name text for skipped ostree tests to explain
why the test is skipped.
Add tests/tasks/ostree_systems_check.yml for use by test
playbooks that may be skipped on ostree systems.

Signed-off-by: Rich Megginson <[email protected]>
@richm richm force-pushed the ostree-skip-test-better-text branch from d0b1296 to ea3c40c Compare March 25, 2024 18:47
@richm
Copy link
Contributor Author

richm commented Mar 25, 2024

[citest]

@richm
Copy link
Contributor Author

richm commented Mar 25, 2024

fedora 39 test hung so I killed it - every test passed except the one that hung - the hang is unrelated to this change

@richm richm merged commit ab77dd1 into linux-system-roles:main Mar 25, 2024
32 of 33 checks passed
@richm richm deleted the ostree-skip-test-better-text branch March 25, 2024 23:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Wait_Submitter The submitter needs to do something before this can move on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants