Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix single app issue #535

Merged
merged 2 commits into from
Sep 27, 2024
Merged

fix: Fix single app issue #535

merged 2 commits into from
Sep 27, 2024

Conversation

re2zero
Copy link
Contributor

@re2zero re2zero commented Sep 26, 2024

If the process crashed and then can not be launched. Use lock file to check.

Log: Fix can not be launched after crash.
Bug: https://pms.uniontech.com/bug-view-275523.html

If the process crashed and then can not be launched. Use lock file to check.

Log: Fix can not be launched after crash.
Bug: https://pms.uniontech.com/bug-view-275523.html
The transfer history did not be writed after receive file from old protocol client.

Log: Fix transfer history not update issue.
Bug: https://pms.uniontech.com/bug-view-275517.html
@deepin-ci-robot
Copy link

deepin pr auto review

关键摘要:

  • TransferHelper::compatTransJobStatusChanged函数中,新增代码块可能会导致HistoryManager::instance()->writeIntoTransHistory函数在匹配失败时未正确处理空字符串。
  • SingleApplication::checkProcess函数中,新增的QLockFile操作可能会影响跨平台兼容性,需要确认是否适用于所有目标操作系统。
  • SingleApplication::setSingleInstance函数中,新增的QLocalServer::removeServer调用可能会导致潜在的竞态条件,需要确保操作的原子性。

是否建议立即修改:

Copy link
Contributor

@pppanghu77 pppanghu77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very good

@re2zero
Copy link
Contributor Author

re2zero commented Sep 27, 2024

/merge

@deepin-bot
Copy link

deepin-bot bot commented Sep 27, 2024

This pr cannot be merged! (status: blocked)

@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: max-lvs, pppanghu77, re2zero

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@re2zero
Copy link
Contributor Author

re2zero commented Sep 27, 2024

/merge

@deepin-bot deepin-bot bot merged commit c80d339 into linuxdeepin:master Sep 27, 2024
16 checks passed
@re2zero re2zero deleted the bugfix branch September 27, 2024 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants