Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [UI] fix the password display is incomplet #537

Merged
merged 1 commit into from
Oct 9, 2024

Conversation

add-uos
Copy link
Contributor

@add-uos add-uos commented Oct 8, 2024

fix the password for the connection page is not complete in tibetan

Log: fix the password display is incomplete
Bug: https://pms.uniontech.com/bug-view-250623.html

@deepin-bot
Copy link

deepin-bot bot commented Oct 9, 2024

This pr cannot be merged! (status: blocked)

fix the password for the connection page is not complete in tibetan

Log: fix the password display is incomplete
Bug: https://pms.uniontech.com/bug-view-250623.html
@deepin-ci-robot
Copy link

deepin pr auto review

关键摘要:

  • ConnectWidget::initUI()函数中,新增的QSpacerItem可能会导致布局问题,需要确认是否与现有布局策略兼容。
  • ConnectWidget::initConnectLayout()函数中,新增的ipVLayout->addSpacing(14);可能会影响布局美观,应确保这一改动不会破坏现有的布局结构。
  • 检查是否有必要在mainLayoutipVLayout中使用QSpacerItem,如果布局已经足够灵活,则可能不需要添加额外的空白空间。

是否建议立即修改:

  • 是,需要确保布局的改动不会影响用户界面的美观性和功能正确性。如果新增的空白空间会导致布局问题,应立即进行修正。

@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: add-uos, pppanghu77, re2zero

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@re2zero re2zero merged commit e0d24a1 into linuxdeepin:release/v20 Oct 9, 2024
14 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants