[adjacent-windows@klangman] Initial extension commit

[klangman]

Add a new applet that allows the user to define hotkeys that will activate adjacent windows based on desired direction (left, right, up, down and under).

[rcalixte]

You can put the extension.js and settings-schema.json files into a versioned directory, here 5.4, so that versioning is handled for you automatically. Take a look at other extensions for an example.

This looks great though! Congrats on getting this done!

[klangman]

OK.. I can make that change.. How is that better then just having "cinnamon-version": ["5.4"] in the metadata.json?

[rcalixte]

OK.. I can make that change.. How is that better then just having "cinnamon-version": ["5.4"] in the metadata.json?

I think it's still a "required" field (a legacy thing we should probably remove) but the benefits are two-fold:

1. In a 5.4 folder, it automatically supports everything greater to it, i.e. 5.6, 5.8, 6.0, etc.
2. As a maintainer, you don't have to open a pull request just to update a metadata file when every new version of Cinnamon comes out. You can focus on just making changes per version of Cinnamon as needed.

It's ultimately your call either way. I just want to make sure you're aware of your options.

[klangman]

@rcalixte It was suggested me to that a version of this work should be included in the System_Settings->Keyboard->Shortcuts->Window section. Just wondering what your take is on that? Best to leave it as a extension only, or add shortcuts for this functionality based on the code from this extension?

[rcalixte]

@rcalixte It was suggested me to that a version of this work should be included in the System_Settings->Keyboard->Shortcuts->Window section. Just wondering what your take is on that? Best to leave it as a extension only, or add shortcuts for this functionality based on the code from this extension?

This is actually something we're working on implementing system-wide. Once completed/merged, all Spices with keybinding options will be available in the keyboard module in system settings for configuration. Hopefully, this makes it into Cinnamon 6.2.

[klangman]

This is actually something we're working on implementing system-wide. Once completed/merged, all Spices with keybinding options will be available in the keyboard module in system settings for configuration. Hopefully, this makes it into Cinnamon 6.2.

Oh.. That will be a very nice improvement. Looking forward to that... But in this case I think the guy was asking me if the basic functionality of this applet should be available in Cinnamon without having to install an extension. i.e. A new
focusing section: Keyboard > Shortcuts > Windows > Focusing

I am happy to leave it as an extension only or I can look into adding the basic idea as new entries in the builtin Keyboard shortcuts.

[rcalixte]

I am happy to leave it as an extension only or I can look into adding the basic idea as new entries in the builtin Keyboard shortcuts.

The thinking is that we can leave it as an extension for a while to iron things out and then move it into Cinnamon's core after that, maybe around 6.4 if you're up to it. This lets the extension get fleshed out in case any issues arise but it also means that there won't be a 6 month wait for possible fixes.

Once it's moved, you'll want to cordon off the extension for new versions. See here for an example for doing that with the folder structure mentioned before.