Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Smart-panel, DesktopCube and Flipper: work together #788

Merged
merged 3 commits into from
Dec 2, 2024
Merged

Smart-panel, DesktopCube and Flipper: work together #788

merged 3 commits into from
Dec 2, 2024

Conversation

claudiux
Copy link
Member

@claudiux claudiux commented Dec 1, 2024

Maintainers:

@klangman
@mohammad-sn

This PR replaces #776.

@claudiux claudiux mentioned this pull request Dec 1, 2024
Closed
2 tasks
@claudiux
Copy link
Member Author

claudiux commented Dec 1, 2024

All seems OK now.

@klangman
Copy link
Contributor

klangman commented Dec 1, 2024

LGTM..

I assume you need the settings = ... lines because the context does not see the global one that is set by the Filler/DesktopCube init() functions?

@claudiux
Copy link
Member Author

claudiux commented Dec 1, 2024

This is indeed the case. When you delete these lines, “settings is undefined” errors appear.

@claudiux
Copy link
Member Author

claudiux commented Dec 1, 2024

@klangman Are you OK with these changes?

@claudiux claudiux merged commit 25b2ba2 into linuxmint:master Dec 2, 2024
1 check passed
@claudiux claudiux deleted the smart-panel_DestopCube branch December 2, 2024 01:05
@claudiux
Copy link
Member Author

claudiux commented Dec 2, 2024

@klangman I hadn't read your “LGTM”. So, I merge it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@claudiux @klangman