Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove "p_" from mailadresses, change subject on lists #2

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

jolly-jump
Copy link

  • when the project account is created, remove the leading "p_" from LMN-name.
  • when the maillist account is created, the name of the maillist is now "Verteiler name". ok this is opionated and german...
  • when the mail goes to a maillist, change the subject from "oldsubject" to "[name] oldsubject"
  • add possibility to set the ldap_filter for account creation and the sogo filter as environmental variables
  • add possibility to hardcode an not-verifying SSL-Keys

@PLanB2008
Copy link

Overall, it looks good. However, I’m not in favor of disabling the SSL certificate check. While changing “Mailinglist” to “Verteiler” makes it less technical, I agree, it also conflicts with our principle of designing everything in a more international way. Hardcoding it in German isn’t the right approach. The better solution would be to add an option that allows users to pick their preferred language and then reference this in a lookup table.

I really like the idea of removing the “p_” prefix, but how can we ensure this doesn’t interfere with other mailing lists or users? Currently, sophomorix handles conflict checking.

Just my two cents. Thanks for contributing!

@jolly-jump
Copy link
Author

Hi.
Thanks for the feedback.
I'll revert the german bit, because config option and lookup table is overkill for now.

The "p_" is such a pain in the neck, that I'd rather run in a conflict on the mailcow syncer.

When thinking about conflicts: An admin can always add a proxy address to any user and provoke a conflict on the mailcow syncer. So I am not sure, if sophomorix should be responsible for conflicts regarding an email adress. sophomorix could check a conflict of the local part, for sure, even with all proxy addresses. But then there might be someone using "[email protected]" while "[email protected]" is for a student and resolving the local part conflict is not enough 🙄

Thinking about all this, I am not sure, if the better solution would be, sophomorix would allow a change of the main email-adress of a project and a class.

I will try to change the "p_" replacement part making it optional, on a "if you know what you are doing" warning basis.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants