Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tweaks usage in README to add cache volume #81

Closed
wants to merge 1 commit into from
Closed

tweaks usage in README to add cache volume #81

wants to merge 1 commit into from

Conversation

MattVonVielen
Copy link

linuxserver.io


  • [ x] I have read the contributing guideline and understand that I have made the correct modifications

Description:

I added a new suggested volume to the README to contain the ddclient cache.

Benefits of this PR and context:

Things will usually work just fine without this, but strictly speaking one wants to persist the ddclient cache via volume in addition to the configuration.

Without persisting this cache, every time the container restarts (before the IP address has changed), it will log this warning:

nochg: No update required; unnecessary attempts to change to the current address are considered abusive

When the cache is persisted as suggested, this warning does not occur, yielding one fewer warning in your servers' application logs which requires learning and/or remembering whether it is safe to ignore.

How Has This Been Tested?

Before making the change, I restarted the container and observed the warning in the log.

After making the change, I started the container (the warning persisted, because the volume was initially empty).
I then restarted the container, and observed the warning was absent from the log.

Source / References:

https://askubuntu.com/questions/317662/ddclient-updates-every-time-and-logs-nochg-no-update-required

Things will usually work just fine without this, but strictly speaking
one wants to persist the ddclient cache via volume in addition to the
configuration.

Without persisting this cache, every time the container restarts (before
the IP address has changed), it will log this warning:

```
nochg: No update required; unnecessary attempts to change to the current address are considered abusive
```

When the cache is persisted as suggested, this warning does not occur.
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for opening this pull request! Be sure to follow the pull request template!

@LinuxServer-CI
Copy link
Contributor

I am a bot, here are the test results for this PR:
https://ci-tests.linuxserver.io/lspipepr/ddclient/v3.11.2-pkg-8fd42c56-dev-96b7758f1f527d3669c5b45ad4bd6a89277d38ac-pr-81/index.html
https://ci-tests.linuxserver.io/lspipepr/ddclient/v3.11.2-pkg-8fd42c56-dev-96b7758f1f527d3669c5b45ad4bd6a89277d38ac-pr-81/shellcheck-result.xml

Tag Passed
amd64-v3.11.2-pkg-8fd42c56-dev-96b7758f1f527d3669c5b45ad4bd6a89277d38ac-pr-81
arm64v8-v3.11.2-pkg-8fd42c56-dev-96b7758f1f527d3669c5b45ad4bd6a89277d38ac-pr-81

@aptalca
Copy link
Member

aptalca commented Feb 23, 2024

It would be better to symlink it out to /config/cache than creating/suggesting a separate bind mount

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants