Fix cache issue in root/etc/s6-overlay/s6-rc.d/svc-ddclient/run #86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ddclient expects a file for --cache, not a directory without this fix, ddclient is unable to use /run/ddclient-cache as it's a directory, causing the IP's to be sent to your DNS provider every X minutes, instead of only if it changed
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Thanks for opening this pull request! Be sure to follow the pull request template!
|
I am a bot, here are the test results for this PR:
|
thespad
approved these changes
Jul 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Fixes #85 by adding a file to the end of the --cache parameter. A recent update made it point to a directory, which broke the cache functionality
Benefits of this PR and context:
Fixes #85
How Has This Been Tested?
Tested on Docker on Debian 12 by making the change in code, building a custom image, and running the image. The cache functionality seems to be back as a result.
Source / References: