Forced umask to be a string.
#293
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
|
I am a bot, here are the test results for this PR:
|
nemchik
approved these changes
Nov 14, 2024
|
Thank you for the fast turn around! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
umask, while a number, should be treated as a string in the JSON file. My previous PR failed to address it.Benefits of this PR and context:
It will fix #292
How Has This Been Tested?
The current code works when
umaskis quoted. This PR uses the unquoted string, and quotes it in the code.It worked for me running locally.
Source / References:
The relevant issue is #292.