Separate repo.Repo to registory.Registory and storage.Storage
#27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cache key should be able to be specified with just a tag. However, currently, "extension" is required, so it is implemented with tag and URL.
k1LoW
force-pushed
the
create-registory-and-storage
branch
from
ac842c4
to
510b878
Compare
k1LoW
force-pushed
the
create-registory-and-storage
branch
from
510b878
to
084ca95
Compare
k1LoW
commented
Oct 5, 2023
Comment on lines
+35
to
+36
| registory registory.Registory | ||
| fetcher storage.Fetcher |
There was a problem hiding this comment.
Separate repo.Repo to registory.Registory and storage.Fetcher.
This was referenced Oct 5, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(I would like you to review #26 first.)
ref: #16
Separate the Repository into two roles.