Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add LON net #62

Merged
merged 61 commits into from
Feb 8, 2025
Merged

Add LON net #62

merged 61 commits into from
Feb 8, 2025

Conversation

lipelopesoliveira
Copy link
Owner

@lipelopesoliveira lipelopesoliveira commented Jun 8, 2024

v0.0.8.8 Beta (01/02/2025)

New features

  • Refactor IO_Tools module to improve the code quality and readability.
  • Add unit tests with pytest for the modules:
    • IO_Tools
    • Tools
    • CJSON
    • Framework
    • BuildingBlock
  • Add the LON and LON-A nets as a result of Implementing LON topology #61.
  • Add the FXT and FXT-A nets.
  • Add the geometry module to handle the geometry identification of molecular structures.
  • Now the building blocks are not save by default.
    • The user can activate the save of the building blocks by setting the save_bb variable to True on the Framework class.
    • Adds the PRZN2 as a result of Addition of a bb #71

Bugfixes

  • Fix bond types not following the CCDC conventions.
  • Fix a bug where the folder for building blocks was created even if the user did not want to save the building blocks.
  • Fix a bug where the save_dir was not created if it did not exist.
  • Fix the out_path variable on the Framework class to save the structure on the correct folder.

Known bugs

  • The geometry module is not fully implemented yet.
  • The calculation of bonds is taking too long for large structures.
  • The bonds calculation does not identify the bond types.
  • The bond assignment is done after the structure is created, which can lead to errors in the structure creation. The bond assignment should be done before the structure creation, and the bonds betweeen building blocks should be assigned manually on the creation of the structure.
  • The positioning of the building blocks on FXT and FXT-A nets is still not perfect.
  • On FXT and FXT-A nets the cell parameters for R4 building blocks are not being calculated correctly.
  • The BOR network is not working properly.
  • Some S4 and R4 building blocks are not being positioned correctly on the structure.

Closes #61, Closes #71

@lipelopesoliveira lipelopesoliveira added the 📶 enhancement New feature or request label Jun 8, 2024
@lipelopesoliveira lipelopesoliveira self-assigned this Jun 8, 2024
lipelopesoliveira and others added 22 commits September 3, 2024 16:00
…pdate save_csv and read_xyz function signatures and error handling
…t and improve error handling; update return values to include cell matrix
… libraries for reading CIF files; improve error handling and return values
…writing method, and streamline atom handling
… enhance file writing method, and streamline atom handling
…writing method, and streamline atom handling
…writing method, and streamline atom handling
… file writing method, and streamline atom handling
… writing method, and streamline atom handling
…ce code clarity; remove unused conversion functions.
lipelopesoliveira and others added 28 commits February 1, 2025 20:12
…correct charge label in output; add comprehensive tests for read_xyz functionality
… add save_labels option; remove obsolete test files
@lipelopesoliveira lipelopesoliveira merged commit fc44f5a into master Feb 8, 2025
@lipelopesoliveira lipelopesoliveira deleted the Implement_3D_nets branch February 8, 2025 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📶 enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Addition of a bb Implementing LON topology
1 participant