-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add LON net #62
Open
lipelopesoliveira
wants to merge
34
commits into
master
Choose a base branch
from
Implement_3D_nets
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Add LON net #62
+1,597
−926
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…author name retrieval method
…pdate save_csv and read_xyz function signatures and error handling
…t and improve error handling; update return values to include cell matrix
… libraries for reading CIF files; improve error handling and return values
…and improve file writing method
…writing method, and streamline atom handling
… enhance file writing method, and streamline atom handling
…writing method, and streamline atom handling
…writing method, and streamline atom handling
… file writing method, and streamline atom handling
… writing method, and streamline atom handling
…ce code clarity; remove unused conversion functions.
…ate_empty_CJSON and create_structure_CJSON functions
…e type ignore comments for cellpar_to_cell function calls
…etter error handling
…ieval, and update structure parsing method
…v, refactor test cases for clarity and structure
…r IO_Tools and Tools modules
…correct charge label in output; add comprehensive tests for read_xyz functionality
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the new nets
LON
andLON_A
as a result of #61.It also adds the PRZN2 as a result of #71
Closes #61, Closes #71