Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Try adding guest user library #3

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

partizipation
Copy link
Contributor

@partizipation partizipation commented Feb 12, 2025

we decided to fork django-guest-user and add email and password for the guest authentication. See here

Couldn't get around the circular reference, tried a bunch of things. Code has a bunch of commented out attempts so it's a little messy but maybe this PR helps review.

Tried:

  • all possible order of guest stuff, auth, and apps.users in INSTALLED_APPS
  • importing in different ways from within users/models.py
  • registering in users/apps.py in a couple different ways

@partizipation partizipation requested a review from m4ra February 12, 2025 16:10
@m4ra m4ra force-pushed the jp-2502-guest-accounts branch from c3e2c5d to dc4a661 Compare February 13, 2025 14:02
@m4ra
Copy link
Contributor

m4ra commented Feb 13, 2025

@partizipation @goapunk to enable the guest user from the registration form, I would add the maybe_make_guest_user in the a+ DefaultSingUpForm.save().
In that way we don't need a middleware. and the guest user will behave as a regular one. In the Account Settings we will need a check in the request.user if they have a user.geust relation then we should add the conversion form component instead of regular profile. Or something down this line.

@m4ra m4ra requested a review from goapunk February 13, 2025 14:11
@m4ra
Copy link
Contributor

m4ra commented Feb 13, 2025

@partizipation the signup template to add the login as guest button is here. But I think the registration form is in a separate story.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants