Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pull upstream changes from commerce_promotion #3

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

jacobembree
Copy link

@jacobembree jacobembree commented Dec 31, 2019

The constructor for CommerceContentEntityStorage changed, and PromotionStorage::loadAvailable() got some date improvements.

Link to Drupal.org issue: https://www.drupal.org/project/commerce/issues/2903716

/**
* Allows fee start and end dates to have a time component.
*/
function commerce_fee_post_update_1(array &$sandbox = NULL) {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We shouldn't need this, since it's a "new" module." But I guess some may have had this installed before

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll be happy to remove it if you give me the word. It came in handy for me because I had already installed the broken version in another environment, but now that the update has run I don't need it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants