Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue851 parse province-level vaccination data #876

Merged
merged 4 commits into from
Jul 8, 2021

Conversation

lisphilar
Copy link
Owner

Related issues

#851

What was changed

  • New: parse province-level vaccination data
  • Fix: duplicated citations with DataLoader, use set(citations)
  • Refactoring

@lisphilar lisphilar added this to the Release v2.22.0 milestone Jul 8, 2021
@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Jul 8, 2021

Sourcery Code Quality Report

✅  Merging this PR will increase code quality in the affected files by 2.36%.

Quality metrics Before After Change
Complexity 2.70 ⭐ 2.48 ⭐ -0.22 👍
Method Length 74.16 🙂 69.65 🙂 -4.51 👍
Working memory 9.18 🙂 8.59 🙂 -0.59 👍
Quality 67.04% 🙂 69.40% 🙂 2.36% 👍
Other metrics Before After Change
Lines 694 687 -7
Changed files Quality Before Quality After Quality Change
covsirphy/cleaning/vaccine_data.py 60.72% 🙂 65.44% 🙂 4.72% 👍
covsirphy/loading/dataloader.py 69.76% 🙂 71.00% 🙂 1.24% 👍

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation
covsirphy/loading/dataloader.py DataLoader.lock 5 ⭐ 315 ⛔ 13 😞 42.58% 😞 Try splitting into smaller methods. Extract out complex expressions
covsirphy/loading/dataloader.py DataLoader.read_csv 7 ⭐ 135 😞 14 😞 51.07% 🙂 Try splitting into smaller methods. Extract out complex expressions
covsirphy/cleaning/vaccine_data.py VaccineData.subset 5 ⭐ 136 😞 12 😞 55.87% 🙂 Try splitting into smaller methods. Extract out complex expressions
covsirphy/cleaning/vaccine_data.py VaccineData._cleaning 2 ⭐ 201 😞 10 😞 56.34% 🙂 Try splitting into smaller methods. Extract out complex expressions
covsirphy/loading/dataloader.py DataLoader._add_remote 1 ⭐ 180 😞 8 🙂 63.30% 🙂 Try splitting into smaller methods

Legend and Explanation

The emojis denote the absolute quality of the code:

  • ⭐ excellent
  • 🙂 good
  • 😞 poor
  • ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.


Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!

@codeclimate
Copy link

codeclimate bot commented Jul 8, 2021

Code Climate has analyzed commit 026ed86 and detected 1 issue on this pull request.

Here's the issue category breakdown:

Category Count
Complexity 1

The test coverage on the diff in this pull request is 96.8% (50% is the threshold).

This pull request will bring the total coverage in the repository to 83.0% (0.0% change).

View more on Code Climate.

@lisphilar lisphilar merged commit 5a14306 into master Jul 8, 2021
@delete-merged-branch delete-merged-branch bot deleted the issue851_vacine_province branch July 8, 2021 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant