-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove the usage of challenge code #1761
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I still need to resolve the conflicts, but basically it can be reviewed edit: conflicts resolved. |
kziemianek
reviewed
Jun 9, 2023
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. @@ Coverage Diff @@
## dev #1761 +/- ##
==========================================
- Coverage 18.65% 17.97% -0.69%
==========================================
Files 273 268 -5
Lines 13102 12670 -432
==========================================
- Hits 2444 2277 -167
+ Misses 10658 10393 -265
|
kziemianek
approved these changes
Jun 9, 2023
This was referenced Jun 9, 2023
Kailai-Wang
added a commit
that referenced
this pull request
Jun 26, 2023
This reverts commit 8d8c7cf.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #1739
This is a big PR trying to:
create_identity
andverify_identity
by merging them into one extrinsic:link_identity
metadata
when linking identities - it's never been used so farIdentityContext
. Now it has two fields only:linkBlock
andstatus
TODO:
I'd like to delay the merging of this PR until the other two issues are solved, so that we can have a release with those fixes for IDHub without adding this new
link_identity
feature:DI port on the instance not reachable in browser #1725it's not a blocker right now (but needs to be fixed asap)