Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the usage of challenge code #1761

Merged
merged 17 commits into from
Jun 14, 2023
Merged

Remove the usage of challenge code #1761

merged 17 commits into from
Jun 14, 2023

Conversation

Kailai-Wang
Copy link
Collaborator

@Kailai-Wang Kailai-Wang commented Jun 8, 2023

resolves #1739

This is a big PR trying to:

  • remove IMP mock - it's not used anymore
  • replace the challenge code with sidechain nonce and encrypted identities
  • deprecate create_identity and verify_identity by merging them into one extrinsic: link_identity
  • remove metadata when linking identities - it's never been used so far
  • simplify IdentityContext. Now it has two fields only: linkBlock and status
  • simplify mock-server getter
  • adjust ts-test
  • remove some unnecessary test cases

TODO:

  • re-benchmark the IMP pallet
  • avoid using hardcoded sidechain-nonce in ts-test
  • add example code for DI
  • other TODOs in ts-test

I'd like to delay the merging of this PR until the other two issues are solved, so that we can have a release with those fixes for IDHub without adding this new link_identity feature:

@Kailai-Wang Kailai-Wang self-assigned this Jun 8, 2023
@Kailai-Wang
Copy link
Collaborator Author

Kailai-Wang commented Jun 8, 2023

I still need to resolve the conflicts, but basically it can be reviewed

edit: conflicts resolved.

@Kailai-Wang Kailai-Wang requested a review from a team June 9, 2023 02:26
@higherordertech higherordertech added the C0-breaking Breaking change that will cause existing client to break label Jun 9, 2023
@Kailai-Wang Kailai-Wang requested a review from a team June 9, 2023 10:28
@codecov-commenter
Copy link

codecov-commenter commented Jun 9, 2023

Codecov Report

Merging #1761 (dd946b4) into dev (1f842a2) will decrease coverage by 0.69%.
The diff coverage is 2.77%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##              dev    #1761      +/-   ##
==========================================
- Coverage   18.65%   17.97%   -0.69%     
==========================================
  Files         273      268       -5     
  Lines       13102    12670     -432     
==========================================
- Hits         2444     2277     -167     
+ Misses      10658    10393     -265     
Impacted Files Coverage Δ
primitives/core/src/error.rs 0.00% <ø> (ø)
tee-worker/app-libs/stf/src/helpers.rs 0.00% <0.00%> (ø)
tee-worker/app-libs/stf/src/trusted_call.rs 0.00% <0.00%> (ø)
...orker/core-primitives/node-api/metadata/src/lib.rs 0.00% <ø> (ø)
tee-worker/core-primitives/types/src/lib.rs 0.00% <ø> (ø)
...arentchain/indirect-calls-executor/src/executor.rs 0.00% <0.00%> (ø)
...tchain/indirect-calls-executor/src/filter_calls.rs 0.00% <0.00%> (ø)
...-executor/src/indirect_calls/litentry/batch_all.rs 0.00% <0.00%> (ø)
...cutor/src/indirect_calls/litentry/link_identity.rs 0.00% <0.00%> (ø)
...worker/litentry/core/data-providers/src/graphql.rs 0.00% <ø> (ø)
... and 8 more

... and 2 files with indirect coverage changes

@Kailai-Wang Kailai-Wang changed the title [don't merge]: Remove the usage of challenge code Remove the usage of challenge code Jun 14, 2023
@Kailai-Wang Kailai-Wang merged commit 8d8c7cf into dev Jun 14, 2023
@Kailai-Wang Kailai-Wang deleted the 1739-use-nonce-for-code branch June 14, 2023 04:20
Kailai-Wang added a commit that referenced this pull request Jun 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C0-breaking Breaking change that will cause existing client to break
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace challenge code with sidechain account nonce
4 participants