Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSS update #4

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Conversation

RubyRabelle
Copy link

When browser is at less than 100% the tools on the left bar are jumbled. I changed the width of the toolbar from 61px to 65px to accommodate reduction in browser scale.
before:
image

after:
image

Rabelle Rouser and others added 3 commits August 15, 2017 10:13
Changed toolbar width from 61 to 65px to accommodate browser zooming under 100%
@irskep
Copy link
Member

irskep commented Aug 15, 2017

This is not the core Literally Canvas repo, this is the demo. And changing the sidebar width is not the right solution here because it makes normal zoom look worse!

Literally Canvas development happens over here: https://github.com/literallycanvas/literallycanvas

@RubyRabelle
Copy link
Author

Thanks Steve. Out of curiosity, what browser are you using that makes it look worse with 65px at 100% zoom?

I demo'd your Literally Canvas widget, in the context of one of our larger applications at my work, and our customers (who will primarily be using iPads or Windows with Firefox) were very excited about the possibilities! The jumbled sidebar was the most obvious flaw. I only mentioned it to you in hopes that our local code wouldn't have to deviate from the master copy (in case we ever wanted to upgrade to a node based system. Cheers!

@irskep
Copy link
Member

irskep commented Aug 17, 2017

I mean it adds unnecessary horizontal padding.

Honestly, the CSS of this library is very messy and would be much better if someone refactored it to use flexbox.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants