Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: query utilities and cleanup #159

Merged
merged 17 commits into from
May 6, 2024
Merged

feat: query utilities and cleanup #159

merged 17 commits into from
May 6, 2024

Conversation

cofin
Copy link
Member

@cofin cofin commented Apr 10, 2024

Pull Request Checklist

  • New code has 100% test coverage
  • (If applicable) The prose documentation has been updated to reflect the changes introduced by this PR
  • (If applicable) The reference documentation has been updated to reflect the changes introduced by this PR
  • Pre-Commit Checks were ran and passed
  • Tests were ran and passed

Description

Adds the following:

  • Reduce duplication between async / sync repositories
  • Added SQLQueryRepository
  • Added SQLQueryService to use for raw sql queries that don't map to an declarative base.
  • Helpers from examples to load a json fixtures from a file async and sync
  • Move to_schema to mixin

Close Issue(s)

@cofin cofin requested review from a team as code owners April 10, 2024 19:46
@cofin cofin requested review from a team as code owners May 3, 2024 17:31
@codecov-commenter
Copy link

codecov-commenter commented May 5, 2024

Codecov Report

Attention: Patch coverage is 88.77888% with 34 lines in your changes are missing coverage. Please review.

Project coverage is 90.06%. Comparing base (3201007) to head (d47c272).

Files Patch % Lines
advanced_alchemy/repository/_async.py 82.50% 14 Missing ⚠️
advanced_alchemy/repository/_sync.py 82.50% 14 Missing ⚠️
advanced_alchemy/utils/fixtures.py 80.95% 4 Missing ⚠️
advanced_alchemy/repository/_util.py 98.21% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #159      +/-   ##
==========================================
- Coverage   90.70%   90.06%   -0.65%     
==========================================
  Files          49       50       +1     
  Lines        3272     3321      +49     
==========================================
+ Hits         2968     2991      +23     
- Misses        304      330      +26     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@litestar-org litestar-org deleted a comment from sonarqubecloud bot May 5, 2024
@litestar-org litestar-org deleted a comment from github-actions bot May 5, 2024
@cofin cofin requested a review from Alc-Alc May 5, 2024 23:38
Copy link

sonarqubecloud bot commented May 6, 2024

Copy link

github-actions bot commented May 6, 2024

Documentation preview will be available shortly at https://litestar-org.github.io/advanced-alchemy-docs-preview/159

Copy link
Collaborator

@Alc-Alc Alc-Alc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤌

@cofin cofin merged commit 714a3e8 into main May 6, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants