Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: add uninstall target #110

Merged
merged 1 commit into from
Dec 3, 2023
Merged

Conversation

mvsrgc
Copy link
Contributor

@mvsrgc mvsrgc commented Dec 2, 2023

Pull Request Checklist

  • New code has 100% test coverage
  • (If applicable) The prose documentation has been updated to reflect the changes introduced by this PR
  • (If applicable) The reference documentation has been updated to reflect the changes introduced by this PR
  • Pre-Commit Checks were ran and passed
  • Tests were ran and passed

Description

This PR adds an uninstall target so that users can quickly undo changes to their system made by the install target.

The current make install command places a binary in the user's home directory ($HOME/.local/bin) without explicit consent. This behavior might not be immediately clear to users.

I have not tested the Windows part of the PR because I don't have access to a Windows PC, but it should work based on where PDM claims to install itself to on Windows [0].

[0] The installer will install PDM into the user site and the location depends on the system: $HOME/. local/bin for Unix. %APPDATA%\Python\Scripts on Windows. https://pdm-project.org/latest/

Close Issue(s)

@mvsrgc mvsrgc requested review from cofin and a team as code owners December 2, 2023 20:54
@cofin
Copy link
Member

cofin commented Dec 2, 2023

Thanks for this. @mvsrgc can you run make lint and commit and changes it produces?

@mvsrgc mvsrgc force-pushed the add-uninstall-target branch from c42e523 to 23a1ba7 Compare December 2, 2023 23:31
Copy link

sonarqubecloud bot commented Dec 2, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@mvsrgc
Copy link
Contributor Author

mvsrgc commented Dec 3, 2023

@cofin Done.

@cofin cofin merged commit 43db2c4 into litestar-org:main Dec 3, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants