Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: v0.2.0 overhaul #120

Closed
wants to merge 21 commits into from
Closed

feat: v0.2.0 overhaul #120

wants to merge 21 commits into from

Conversation

cofin
Copy link
Member

@cofin cofin commented Dec 19, 2023

Pull Request Checklist

  • New code has 100% test coverage
  • (If applicable) The prose documentation has been updated to reflect the changes introduced by this PR
  • (If applicable) The reference documentation has been updated to reflect the changes introduced by this PR
  • Pre-Commit Checks were ran and passed
  • Tests were ran and passed

Description

Close Issue(s)

@cofin cofin requested review from a team as code owners December 19, 2023 14:06
JacobCoffee
JacobCoffee approved these changes Dec 19, 2023
View reviewed changes
Copy link
Member

@JacobCoffee JacobCoffee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ooh fancy

@cofin cofin mentioned this pull request Dec 19, 2023
Closed
4 tasks
@cofin cofin linked an issue Dec 19, 2023 that may be closed by this pull request
Bug: running "make lint" reformats the code #75
Closed
4 tasks
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions

17.3% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

@cofin cofin closed this Dec 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JacobCoffee JacobCoffee JacobCoffee approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: running "make lint" reformats the code
2 participants
@cofin @JacobCoffee