Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: dockerfile dev broken in transition to uv #192

Closed
wants to merge 7 commits into from

Conversation

padbk
Copy link
Contributor

@padbk padbk commented Jan 12, 2025

Description

Closes #191

As part of transitioning to uv here #187, both the development and production docker environments were broken. This fixes the development environment. Another fix will be needed for the production environment.

There may be a way to get uv to install node dependencies, but I am not aware of one.

@padbk padbk requested review from cofin and a team as code owners January 12, 2025 14:38
@cofin
Copy link
Member

cofin commented Jan 14, 2025

@padbk Sorry for the delay in responding. I've had some updates that have been pending for a bit and should be merged soon. I think it should resolve the UV build issues, but if it doesn't lets revisit this.

@padbk
Copy link
Contributor Author

padbk commented Jan 15, 2025

@cofin Thanks. I have tried the new version on main, it didn't have uv installed, but even after adding that, vite does not start. I will take a further look and update this PR with any suggestions.

@padbk
Copy link
Contributor Author

padbk commented Jan 15, 2025

@cofin I've added some more suggested fixes, but currently vite and therefore the frontend are not starting for me. I'm unsure what to change as your recent changes are far reaching. Hope you can look into this please 🙏

@cofin
Copy link
Member

cofin commented Jan 17, 2025

@padbk I did have a chance to verify (and correct) the dev dockerfile. See the last PR I submitted for running the production and dev image. Hopefully, this addresses most (or all) of the issues.

@BradLucky
Copy link

I don't know if this helps, but I just cloned this repo and was (almost) able to docker compose up. I did not run into troubles with uv installing, but I did get a collision on port 8000. There are changes in this PR that appear to address the issue the same way that I did (change 8000 to 8080). That worked for me, as well.

However, all of the other changes to Dockerfile are committed to the main branch, i.e. installing uv and running uv sync, as well as the couple environment variables in here for Vite.

@padbk
Copy link
Contributor Author

padbk commented Jan 18, 2025

@cofin Thank you for making the changes, much appreciated. I hadn't spotted that nodeenv/bin needed to be added to PATH. main is working for me now. Closing this PR and associated issue.

@BradLucky The only collision I can see on port 8000 is with the docs at /schema. So that route can't be used in the frontend, but everything else seems ok?

@padbk padbk closed this Jan 18, 2025
@padbk padbk deleted the padbk-dockerdev branch January 18, 2025 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Docker dev environment broken since migration to uv
3 participants