-
-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: dockerfile dev broken in transition to uv #192
Conversation
@padbk Sorry for the delay in responding. I've had some updates that have been pending for a bit and should be merged soon. I think it should resolve the UV build issues, but if it doesn't lets revisit this. |
@cofin Thanks. I have tried the new version on main, it didn't have |
@cofin I've added some more suggested fixes, but currently vite and therefore the frontend are not starting for me. I'm unsure what to change as your recent changes are far reaching. Hope you can look into this please 🙏 |
@padbk I did have a chance to verify (and correct) the dev dockerfile. See the last PR I submitted for running the production and dev image. Hopefully, this addresses most (or all) of the issues. |
I don't know if this helps, but I just cloned this repo and was (almost) able to However, all of the other changes to |
|
@cofin Thank you for making the changes, much appreciated. I hadn't spotted that @BradLucky The only collision I can see on port 8000 is with the docs at |
Description
Closes #191
As part of transitioning to uv here #187, both the development and production docker environments were broken. This fixes the development environment. Another fix will be needed for the production environment.
There may be a way to get uv to install node dependencies, but I am not aware of one.