Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update usage/channels #3351

Merged
merged 9 commits into from
Jan 10, 2025
Merged

docs: update usage/channels #3351

merged 9 commits into from
Jan 10, 2025

Conversation

JacobCoffee
Copy link
Member

Description

Closes

@JacobCoffee JacobCoffee added the no changelog Do not add this entry to the changelog label Apr 9, 2024
@JacobCoffee JacobCoffee requested review from a team as code owners April 9, 2024 03:59
@github-actions github-actions bot added area/docs This PR involves changes to the documentation size: small type/docs pr/internal labels Apr 9, 2024
@JacobCoffee
Copy link
Member Author

I recommend reviewing with whitespace changes off because the diff is stupid

docs/usage/channels.rst Show resolved Hide resolved
docs/usage/channels.rst Outdated Show resolved Hide resolved
docs/usage/channels.rst Outdated Show resolved Hide resolved
@JacobCoffee
Copy link
Member Author

ready

Copy link

sonarqubecloud bot commented Apr 9, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

docs/usage/channels.rst Show resolved Hide resolved
docs/usage/channels.rst Show resolved Hide resolved
docs/usage/channels.rst Outdated Show resolved Hide resolved
docs/usage/channels.rst Show resolved Hide resolved
docs/usage/channels.rst Outdated Show resolved Hide resolved
docs/usage/channels.rst Outdated Show resolved Hide resolved
Copy link

codecov bot commented Jan 5, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.34%. Comparing base (7982793) to head (8a6ac06).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3351   +/-   ##
=======================================
  Coverage   98.34%   98.34%           
=======================================
  Files         347      347           
  Lines       15727    15727           
  Branches     1738     1738           
=======================================
  Hits        15467    15467           
  Misses        124      124           
  Partials      136      136           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cofin cofin dismissed stale reviews from provinzkraut and peterschutt January 10, 2025 03:50

Cleaning up; Changes merged

Copy link
Member

@cofin cofin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Let's open up a followup if there are additional tweaks needed.

@cofin cofin enabled auto-merge (squash) January 10, 2025 03:57
@cofin cofin merged commit a814224 into main Jan 10, 2025
25 checks passed
@cofin cofin deleted the docs-channels branch January 10, 2025 03:58
Copy link

Documentation preview will be available shortly at https://litestar-org.github.io/litestar-docs-preview/3351

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/docs This PR involves changes to the documentation no changelog Do not add this entry to the changelog pr/internal size: small type/docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants