chore: pin to Python 3.12 for docs commands only; fix contributing docs #3953
Conversation
github-actions
bot
added
area/docs
|
@all-contributors add @sloria for docs |
|
I've put up a pull request to add @sloria! 🎉 |
|
hm, i hope i did things right 😬 |
CONTRIBUTING.rst
Outdated
|
|
||
| uv install | ||
| uv sync --python 3.12 |
There was a problem hiding this comment.
Selecting a python version isn't really necessary here, and if you do select one, it should be the lowest supported version
There was a problem hiding this comment.
this was to align with the Makefile here:
Line 32 in bb6aa49
should I change both to use 3.8?
fwiw, uv sync won't work its own doesn't work if you have python 3.13 installed. building the docs raises an error because picologging (which isn't python 3.13 compatible) isn't installed (it gets conditionally installed on python<3.13).
There was a problem hiding this comment.
Hmm. For docs we should probably install --python=3.12 then and omit a specific version for everything else.
sloria
changed the title
| @@ -29,7 +29,7 @@ upgrade: ## Upgrade all dependencies to the latest stable versio | |||
|
|
|||
| .PHONY: install | |||
| install: | |||
| @uv sync --python 3.12 | |||
| @uv sync | |||
There was a problem hiding this comment.
might want to add --frozen so people don't inadvertently update the lockfile, but i'm not 100% sure so left that alone
|
Documentation preview will be available shortly at https://litestar-org.github.io/litestar-docs-preview/3953 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3953 +/- ##
==========================================
- Coverage 98.34% 98.34% -0.01%
==========================================
Files 347 347
Lines 15743 15743
Branches 1740 1740
==========================================
- Hits 15483 15482 -1
- Misses 124 126 +2
+ Partials 136 135 -1 ☔ View full report in Codecov by Sentry. |
Description
Closes