-
-
Notifications
You must be signed in to change notification settings - Fork 401
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(debugger): passing debugger to app #3967
feat(debugger): passing debugger to app #3967
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3967 +/- ##
=======================================
Coverage 98.35% 98.35%
=======================================
Files 347 348 +1
Lines 15811 15821 +10
Branches 1747 1747
=======================================
+ Hits 15551 15561 +10
Misses 124 124
Partials 136 136 ☔ View full report in Codecov by Sentry. |
@sobolevn I'd like if you review me |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some minor comments on my side, though I wasnt able to be sent into pdb on an exception, is it working or im doing something stupid ?
using this app:
import pdb
import uvicorn
from litestar import Litestar, get
@get("/")
async def exc() -> str:
1 / 0
return "Hello World"
app = Litestar(route_handlers=[exc], debugger_module=pdb, debug=True)
if __name__ == "__main__":
uvicorn.run(
"qq:app",
reload=True,
)
ok answering to myself why I couldnt pop in pdb, it is because requires |
Yeah, you're right, ty |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM thanks !
…ost_mortem() protocol
…ost_mortem() protocol
…pdate import statements
Co-authored-by: Janek Nouvertné <provinzkraut@posteo.de>
0dfd519
to
e07f5a7
Compare
Documentation preview will be available shortly at https://litestar-org.github.io/litestar-docs-preview/3967 |
Description
Passing
debugger_module
variable to apppost_mortem
methodCloses
#3949