Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds a new configuration for the server in order to control server me… #1050

Merged
merged 7 commits into from
Nov 25, 2024

Conversation

eduwercamacaro
Copy link
Member

…tric levels

Copy link
Member

@coltmcnealy-lh coltmcnealy-lh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@coltmcnealy-lh
Copy link
Member

The only thing missing is a documentation of what are the valid levels and what do they do? Can you put that into SERVER_CONFIGURATIONS.md, and also in LHServerConfig validate that the provided level is valid?

@eduwercamacaro eduwercamacaro marked this pull request as ready for review November 25, 2024 03:18
Copy link
Member

@coltmcnealy-lh coltmcnealy-lh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Huge improvement

@eduwercamacaro eduwercamacaro merged commit 72c9e57 into master Nov 25, 2024
16 checks passed
@eduwercamacaro eduwercamacaro deleted the server-metrics-level branch November 25, 2024 22:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants